Skip to content

SPMI: Add fallback for notifyInstructionSetUsage #112925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
Feb 26, 2025
Merged

SPMI: Add fallback for notifyInstructionSetUsage #112925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,9 +811,21 @@ bool MethodContext::repNotifyInstructionSetUsage(CORINFO_InstructionSet isa, boo
DD key{};
key.A = (DWORD)isa;
key.B = supported ? 1 : 0;
DWORD value = LookupByKeyOrMiss(NotifyInstructionSetUsage, key, ": key %u-%u", key.A, key.B);
DEBUG_REP(dmpNotifyInstructionSetUsage(key, value));
return value != 0;

if (NotifyInstructionSetUsage != nullptr)
{
int index = NotifyInstructionSetUsage->GetIndex(key);
if (index != -1)
{
DWORD value = NotifyInstructionSetUsage->GetItem(index);
DEBUG_REP(dmpNotifyInstructionSetUsage(key, value));
return value != 0;
}
}

// Fall back to most likely implementation instead of missing, since ISA
// usage changes are quite common on normal JIT changes.
return supported;
}

void MethodContext::recGetMethodAttribs(CORINFO_METHOD_HANDLE methodHandle, DWORD attribs)
Expand Down
Loading