Skip to content

Annotate System.Text.Json for nullable #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buyaa-n wants to merge 10 commits into from
Closed

Annotate System.Text.Json for nullable #114

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a649816
Annotate System.Text.Json for nullable
buyaa-n Nov 18, 2019
5015584
Suppressing null warnings on non NetCoreApp targets
buyaa-n Nov 19, 2019
44d82fd
Suppress more error in other env
buyaa-n Nov 19, 2019
3a7254b
Annotate netstandard dependent file
buyaa-n Nov 19, 2019
6917d64
Some more update
buyaa-n Nov 19, 2019
150691f
Enebling nullability on file which fialing for other projects
buyaa-n Nov 20, 2019
0ab2dd6
Disabling nullable warning on netfx, netstandard
buyaa-n Nov 20, 2019
8459413
Addressing feedback
buyaa-n Nov 21, 2019
ea28014
Banging Exception.Message instead of defaulting as tests failing
buyaa-n Nov 21, 2019
9d735b7
Applying feedback
buyaa-n Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppressing null warnings on non NetCoreApp targets
  • Loading branch information
@buyaa-n
buyaa-n committed Nov 19, 2019
commit 5015584fb4aefd13a666b37a7d4f477dde02ffe6
1 change: 1 addition & 0 deletions src/libraries/System.Text.Json/src/System.Text.Json.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- https://github.com/dotnet/arcade/blob/ea6addfdc65e5df1b2c036f11614a5f922e36267/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectDefaults.props#L90 -->
<!-- For this project, we want warnings if there are public APIs/types without properly formatted XML comments (particularly CS1591). -->
<NoWarn />
<NoWarn Condition="'$(TargetsNetCoreApp)' != 'true'">$(NoWarn);8600;8601;8602;8603;8604</NoWarn>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
Expand Down