Skip to content

ProviderAliasAttribute moved to Microsoft.Extensions.Logging.Abstractions solution. #114606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

ProviderAliasAttribute moved to Microsoft.Extensions.Logging.Abstractions solution. #114606

merged 1 commit into from
Apr 14, 2025

Conversation

@SetTrend
Copy link
Contributor

@SetTrend SetTrend commented Apr 13, 2025

resolves #114532

@ghost
Copy link

ghost commented Apr 13, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Apr 13, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 13, 2025
@build-analysis build-analysis bot mentioned this pull request Apr 13, 2025
Open
@tarekgh tarekgh added this to the 10.0.0 milestone Apr 13, 2025
@tarekgh tarekgh mentioned this pull request Apr 13, 2025
Closed
@SetTrend SetTrend closed this Apr 14, 2025
@build-analysis build-analysis bot mentioned this pull request Apr 14, 2025
Open
@SetTrend SetTrend reopened this Apr 14, 2025
@build-analysis build-analysis bot mentioned this pull request Apr 14, 2025
Closed
@SetTrend
Microsoft.Extensions.Logging.ProviderAliasAttribute moved to `Micro…
ab6d4cb 
…soft.Extensions.Logging.Abstractions` solution.
@tarekgh tarekgh marked this pull request as ready for review April 14, 2025 16:52
@tarekgh tarekgh added breaking-change Issue or PR that represents a breaking API or functional change over a previous release. and removed new-api-needs-documentation labels Apr 14, 2025
@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 14, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 14, 2025 •
edited by tarekgh
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@build-analysis build-analysis bot mentioned this pull request Apr 14, 2025
Open
3 tasks
@tarekgh tarekgh mentioned this pull request Apr 14, 2025
Closed
3 tasks
@tarekgh tarekgh removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 14, 2025
@tarekgh
Copy link
Member

tarekgh commented Apr 14, 2025

The breaking change doc issue dotnet/docs#45806 is filed.

@tarekgh
Copy link
Member

tarekgh commented Apr 14, 2025

/ba-g the build failure is unrelated

@tarekgh tarekgh merged commit b044b20 into dotnet:main Apr 14, 2025
87 of 91 checks passed
@tarekgh
Copy link
Member

tarekgh commented Apr 14, 2025

Thanks @SetTrend for providing the change.

@ericstj ericstj changed the title WIP: ProviderAliasAttribute moved to Microsoft.Extensions.Logging.Abstractions solution. ProviderAliasAttribute moved to Microsoft.Extensions.Logging.Abstractions solution. Apr 21, 2025
This was referenced May 19, 2025
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekgh tarekgh tarekgh approved these changes

+1 more reviewer

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-Logging breaking-change Issue or PR that represents a breaking API or functional change over a previous release. community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: ProviderAliasAttribute: Better move to Microsoft.Extensions.Logging.Abstractions

3 participants

@SetTrend @tarekgh @KalleOlaviNiemitalo