Skip to content

Conversation

@kamronbatman
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 15, 2025 06:29
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2025
@MihaZupan
Copy link
Member

The existing comment looks more correct to me.
You aren't talking about a single callback invocation, but about the same callback being invoked over and over again.
Hence the chain of callbacks stops, not that a single callback stops.

@kamronbatman
Copy link
Contributor Author

kamronbatman commented Apr 15, 2025

The existing comment looks more correct to me. You aren't talking about a single callback invocation, but about the same callback being invoked over and over again. Hence the chain of callbacks stops, not that a single callback stops.

I'll be happy to revert that part. I think the a to an still makes sense. I know it's a super minor nit of a change.

@kamronbatman
Copy link
Contributor Author

@MihaZupan - reverted the change you were talking about and left the two a -> an changes. Should be good to go?

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@MihaZupan
Copy link
Member

This seems to be a more common typo: https://grep.app/search?f.repo=dotnet%2Fruntime&f.repo.pattern=runtime&regexp=true&q=%5B%5Ea-z%5Da+object
Mind find-replaceing all of them?

@teo-tsirpanis teo-tsirpanis removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 31, 2025
@mangod9 mangod9 added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 23, 2025
@dotnet-policy-service
Copy link
Contributor

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@dotnet-policy-service
Copy link
Contributor

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-GC-coreclr community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants