Optimize ArgumentOutOfRangeException throw helpers

[xtqqczze]

• Move throw helpers to ThrowHelpers
• Reduce code size by boxing early

[jkotas]

I do not see any end-to-end improvements here, only regressions.

[MihaZupan]

What's the intention behind optimizing the cold throw helpers?
The hot paths that call into them don't care about how much logic there is in them as they should never be inlined regardless.

[xtqqczze]

What's the intention behind optimizing the cold throw helpers?

Purely to reduce code size, since the generic methods end up being instantiated with many different types.

[xtqqczze]

they should never be inlined regardless.

I wonder why they are inlined for Vector<float>: https://csharp.godbolt.org/z/rqxa1q7G6

[tannergooding]

Vector<T> is a special type that gives an inlining profitability boost when used/encountered. It's effectively special and this is probably an area that should be adjusted to say "don't do that if the path is known to be cold"

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

[krwq]

@xtqqczze thanks for attempts on improving this. Looking at MichalStrehovsky/rt-sz#188 this looks like it's regressing more than it optimizes. Please let us know if you'll be trying to improve this or if we should close this PR.