-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add MetadataUpdateDeletedAttribute #119584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
76e9c90
Add MetadataUpdateDeletedAttribute
steveisok 49f2f0c
Add ability to filter members in reflection and test
steveisok da6eb20
Feedback and tests
tmat 443c508
Merge branch 'main' into add-ref-filter-attr
tmat 3a6e602
More feedback
tmat 71a90f9
Fix typo
tmat 985f9ea
Cleanup
tmat d408768
Cleanup
tmat c6c314f
Fix ref assembly formatting
steveisok 34cc104
Merge remote-tracking branch 'upstream/main' into add-ref-filter-attr
steveisok 0f4eeb0
Fix
tmat b15b9bb
Fix test
tmat 7755689
Disable test on Mono
tmat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 0 additions & 34 deletions
34
src/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/libraries/System.Collections.Specialized/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...tem.Reflection.Metadata.ApplyUpdate.Test.ReflectionDeleteMethod/ReflectionDeleteMethod.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace System.Reflection.Metadata.ApplyUpdate.Test | ||
| { | ||
| public class ReflectionDeleteMethod | ||
| { | ||
| public string Id { get; set;} | ||
|
|
||
| public string Name { get; set; } | ||
|
|
||
| public string FullName { get; set; } | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
....Reflection.Metadata.ApplyUpdate.Test.ReflectionDeleteMethod/ReflectionDeleteMethod_v1.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace System.Reflection.Metadata.ApplyUpdate.Test | ||
| { | ||
| public class ReflectionDeleteMethod | ||
| { | ||
| public string Id { get; set;} | ||
|
|
||
| public string Name { get; set; } | ||
|
|
||
| [System.Runtime.CompilerServices.MetadataUpdateDeleted] | ||
tmat marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| public string FullName { get; set; } | ||
| } | ||
| } | ||
11 changes: 11 additions & 0 deletions
11
...ionDeleteMethod/System.Reflection.Metadata.ApplyUpdate.Test.ReflectionDeleteMethod.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <RootNamespace>System.Runtime.Loader.Tests</RootNamespace> | ||
| <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> | ||
| <TestRuntime>true</TestRuntime> | ||
| <DeltaScript>deltascript.json</DeltaScript> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="ReflectionDeleteMethod.cs" /> | ||
| </ItemGroup> | ||
| </Project> |
6 changes: 6 additions & 0 deletions
6
...pdate/System.Reflection.Metadata.ApplyUpdate.Test.ReflectionDeleteMethod/deltascript.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "changes": [ | ||
| {"document": "ReflectionDeleteMethod.cs", "update": "ReflectionDeleteMethod_v1.cs"} | ||
| ] | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.