Update comments for CA1825 suppression #119899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update comments for CA1825: Avoid zero-length array allocations It is not correct that `Array.Empty<T>()` doesn't exist in all configurations, the API is available from .NET Standard 1.3.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
eiriktsarpalis
removed
the
needs-area-label
| #pragma warning disable CA1825 | ||
| // Array.Empty<T>() doesn't exist in all configurations | ||
| // Switching to Array.Empty also has a non-negligible impact on the working set memory | ||
| #pragma warning disable CA1825 // avoid the extra generic instantiation for Array.Empty<T>() |
Member
There was a problem hiding this comment.
This change is removing important context from the implementation, why make it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update comments for CA1825: Avoid zero-length array allocations
It is not correct that
Array.Empty<T>()doesn't exist in all configurations, the API is available from .NET Standard 1.3.