include memory required to do MethodDefLookup in minidumps #120119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #119921
While working on #119965, I ran into another issue where we expect to be able to map MethodDef -> MethodDesc using the LookupMap on the module for methods on the stack in minidump scenarios. #119111 inadvertently removed the call to
Module::LookupMethodDef
fromGetIL
where it was enumerated. As a fix, I modifiedMethodDesc::EnumMemoryRegions
to explicitly enumerate it.Sample call stack from before #119111 was merged: