Skip to content

[release/9.0-staging] [mono][hotreload] Make the runtime ignore an update if it is an empty one #120335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 2 commits into from
Oct 4, 2025
Merged

[release/9.0-staging] [mono][hotreload] Make the runtime ignore an update if it is an empty one #120335

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06ce4fc
If we receive an empty update we should just ignore it.
thaystg Oct 2, 2025
c2bd74e
Update src/mono/mono/component/hot_reload.c
thaystg Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
If we receive an empty update we should just ignore it.
  • Loading branch information
@thaystg
thaystg authored and github-actions committed Oct 2, 2025
commit 06ce4fc9fa2f0dcd7ffbf57b3a9046ab08268a77
6 changes: 4 additions & 2 deletions src/mono/mono/component/hot_reload.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2381,9 +2381,11 @@ hot_reload_apply_changes (int origin, MonoImage *image_base, gconstpointer dmeta
if (!assembly_update_supported (image_base, error)) {
return;
}

if (dmeta_bytes == 0 && dil_bytes_orig == 0) //we may receive empty updates
{
return;
}
static int first_origin = -1;

if (first_origin < 0) {
first_origin = origin;
}
Expand Down