Skip to content

JIT: Optimize "constant_string".Length #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BruceForstall merged 23 commits into from
Feb 14, 2020
Merged

JIT: Optimize "constant_string".Length #1378

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
370b761
Add GetStringLength() to jit interface
EgorBo Jan 7, 2020
e3e889e
Use `gen.bat` to update crossgen2
EgorBo Jan 7, 2020
9adda2a
Implement the actual optimization
EgorBo Jan 7, 2020
2776a5a
Code formatting
EgorBo Jan 7, 2020
faac68e
return -1 for crossgen2 (TODO: implement)
EgorBo Jan 8, 2020
5caee61
Disable for R2R
EgorBo Jan 8, 2020
0be9bbd
remove `pString != nullptr` check (it's ok for empty strings)
EgorBo Jan 10, 2020
e906aad
does order matter? (in ThunkInput.txt)
EgorBo Jan 10, 2020
fec26b2
Merge branch 'master' of github.com:dotnet/runtime into opt-string-le…
EgorBo Jan 12, 2020
286d7a9
Rename to GetStringLiteral
EgorBo Jan 13, 2020
1596fd9
Fix build errors
EgorBo Jan 13, 2020
6ce3207
Merge branch 'master' of github.com:dotnet/runtime into opt-string-le…
EgorBo Jan 27, 2020
9703fe3
Address feedback
EgorBo Jan 27, 2020
067e21d
handle null return value
EgorBo Jan 27, 2020
db6e94e
fix build
EgorBo Jan 27, 2020
7fd4d87
Address feedback
EgorBo Jan 27, 2020
183aea0
fix merge conflict
EgorBo Jan 27, 2020
76d984e
add comments in corinfo.h
EgorBo Jan 27, 2020
becc851
Address feedback
EgorBo Jan 28, 2020
91a4a26
Update ThunkGenerator.csproj
EgorBo Jan 28, 2020
eb99781
remove HackishString thing
EgorBo Jan 30, 2020
d6533b4
Update importer.cpp
EgorBo Jan 31, 2020
0940e93
Map wchar_t to C# char in ThunkInput.txt
EgorBo Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable for R2R
  • Loading branch information
@EgorBo
EgorBo committed Jan 8, 2020
commit 5caee6198a97b9d2bef3a7586bf7c54ae4ba4c9f
2 changes: 1 addition & 1 deletion src/coreclr/src/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3632,7 +3632,7 @@ GenTree* Compiler::impIntrinsic(GenTree* newobjThis,
op1 = impPopStack().val;
if (opts.OptimizationEnabled())
{
if (op1->OperIs(GT_CNS_STR))
if (!opts.IsReadyToRun() && op1->OperIs(GT_CNS_STR))
{
// Optimize `ldstr + String::get_Length()` to CNS_INT
// e.g. "Hello".Length => 5
Expand Down