-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Enable NetworkAddressChange on FreeBSD #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable NetworkAddressChange on FreeBSD #1602
Conversation
|
cc @wfurt |
|
Resolved merge conflicts. @stephentoub, @wfurt, could you please give it another pass? Thanks. |
wfurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks @am11.
| { | ||
| onNetworkChange(sock, AvailabilityChanged); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: why are the braces needed here but not for the other cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in #2071.
Managed code is shared between Linux and FreeBSD, native parts are implemented alongside Linux, using
route(4).To run the unit tests, used corefx 3.0 build of corefx (Debug), coreclr and core-setup (Release). Then cherry-picked the bits back to runtime master. (haven't tried building entire dotnet/runtime repo on FreeBSD yet)
To test the native implementation, following technique was used:
then in a separate terminal:
Fixes dotnet/corefx#33530