-
Notifications
You must be signed in to change notification settings - Fork 5.3k
HttpClient throws TimeoutException wrapped by TaskCancellationException when request times out #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alnikola
merged 16 commits into
dotnet:master
from
alnikola:alnikola/20296-httpclient-timeout-exception
Feb 19, 2020
Merged
HttpClient throws TimeoutException wrapped by TaskCancellationException when request times out #2281
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
93bc5b2
HttpClient throws TimeoutException wrapped by TaskCancelledException …
alnikola 70a0389
Timer is disposed on all exceptions
alnikola 935d893
Timeout's conversion to long is removed as unnecessary
alnikola 355cd80
ExceptionDispatchInfo.Capture removed
alnikola ad0cad8
Update src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs
alnikola 8347c67
Redundant using removed
alnikola e1a84bf
Merge branch 'alnikola/20296-httpclient-timeout-exception' of https:/…
alnikola 29aaa4a
- _pendingRequestCts check removed
alnikola aa543d0
- CancelAfter is brought back
alnikola 192ea1d
TimeoutException is not thrown if the caller canceled the token
alnikola 04fdd78
More unit tests
alnikola 46f2191
Multiple small changes to address comments
alnikola 730b6f0
Tests use ThrowsAny<OperationCancelledException>()
alnikola 7a01b85
A few optimizations
alnikola 6adf5c3
Code style fix
alnikola 7ea3e19
Merge branch 'master' into alnikola/20296-httpclient-timeout-exception
alnikola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
More unit tests
- Loading branch information
commit 04fdd789794224cd6157ec1fa18506ba5d819945
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.