Merging small assemblies (part 2/N) #31991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2020
Member
Author
|
Resolved conflicts. @ericstj Could you please take look? |
Member
|
Do you think we need TypeForwardedFrom attribute on any other types? Any of those |
ericstj
approved these changes
Feb 18, 2020
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
LGTM modulo enum concern (and merge conflicts)
Member
Author
I do not see any such type in the list. (As always, there is some small chance that somebody may be depending on the assembly identity of one of these types, but that is impossible to predict.) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2138