-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Honor converters for underlying types of Nullable<T> specified with JsonConverterAttribute #32006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
layomia
merged 14 commits into
dotnet:master
from
CodeBlanch:JsonConverterAttribute+NullableType
Feb 29, 2020
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
13a092b
FIxed exception being thrown when JsonConverterAttribute is used on N…
CodeBlanch e91a0b8
Expanded test coverage.
CodeBlanch 947159d
Code review feedback.
CodeBlanch 44d65eb
Code review feedback.
CodeBlanch e866c90
Syncing up with master.
CodeBlanch 07348b2
Updated to use JsonValueConverterNullableFactory directly instead of …
CodeBlanch 8251e33
Null response is no longer possible.
CodeBlanch ab723f5
Code review.
CodeBlanch 5d7e4eb
Sync up with master.
CodeBlanch 96857fe
Updated for refactoring.
CodeBlanch 0f71de6
Merge branch 'master' into JsonConverterAttribute+NullableType
CodeBlanch 1aee7fb
Code review.
CodeBlanch 07d457e
Code review #2.
CodeBlanch d5fa634
Merge branch 'master' into JsonConverterAttribute+NullableType
CodeBlanch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Code review feedback.
- Loading branch information
commit 947159d9d398c03900ae65a0690d7768f8b77280
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.