Bail out on CORINFO_STATIC_FIELD_ADDRESS like Crossgen1 does #32664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the main problem after I overcame initial issues with composite R2R debugging and runtime initialization: for some reason, console output was weirdly distorted. By selectively compiling just a subset of the framework I bisected this into System.Console.get_Out which uses the ldsflda instruction that Crossgen1 doesn't support. We pretended to support it but did it incorrectly and so our result didn't match JIT. I have created the tracking issue dotnet#32663 on implementing the static address as a minor perf optimization (likely only important in some corner scenarios heavily using statics). Thanks Tomas
jkotas
approved these changes
Feb 21, 2020
Such messages prevents from NgenDump with crossgen2 on a broken 10wd5.cs test. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the main problem after I overcame initial issues with
composite R2R debugging and runtime initialization: for some reason,
console output was weirdly distorted. By selectively compiling
just a subset of the framework I bisected this into
System.Console.get_Out which uses the ldsflda instruction that
Crossgen1 doesn't support. We pretended to support it but did it
incorrectly and so our result didn't match JIT. I have created
the tracking issue
#32663
on implementing the static address as a minor perf optimization
(likely only important in some corner scenarios heavily using
statics).
Thanks
Tomas