Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
b9e701e
Enable restore for ref and src projects in libs
ViktorHofer Mar 12, 2020
f9f120a
Rename .builds to .proj files in libraries
ViktorHofer Mar 13, 2020
444f49f
Enable RestoreUseStaticGraphEvaluation
ViktorHofer Mar 13, 2020
0bf42c0
RestoreGraph fixes
ViktorHofer Mar 13, 2020
f6dce74
Use private TargetFramework.Sdk package
ViktorHofer Mar 13, 2020
99b837c
Update global.json
ViktorHofer Mar 21, 2020
050280a
Introduce subsets
ViktorHofer Mar 23, 2020
79715c4
Rename .builds to .proj
ViktorHofer Mar 23, 2020
f11dbd9
Depproj restore fixes
ViktorHofer Mar 23, 2020
12e3116
traversal code cleanup
ViktorHofer Mar 23, 2020
534b233
Package fixes
ViktorHofer Mar 23, 2020
786700a
Add missing pinvoke exceptions
ViktorHofer Mar 23, 2020
ddfe69b
Move Tfm defines to Configurations.props
ViktorHofer Mar 23, 2020
25a5a58
Build fixes for runtime.depproj and cleanup
ViktorHofer Mar 23, 2020
5b71e82
Bring solution support back
ViktorHofer Mar 23, 2020
95befac
Subset and yml fixes
ViktorHofer Mar 23, 2020
c2b3a93
runtime.depproj fixes for restore
ViktorHofer Mar 23, 2020
2effd4c
Update subset rename
ViktorHofer Mar 23, 2020
bb5e0e7
Fix runtime.depproj tfm
ViktorHofer Mar 23, 2020
872d5b4
Traversal support
ViktorHofer Mar 25, 2020
65b1863
Update TargetFramework.Sdk
ViktorHofer Mar 25, 2020
0dbcec2
Add required PackageReferences
ViktorHofer Mar 25, 2020
6385ce2
Sequence GenerateRuntimeOSPropsFile correctly
ViktorHofer Mar 25, 2020
95f4fd6
Avoid packages.proj binclashes
ViktorHofer Mar 25, 2020
08fcf2e
Avoid dirs.proj binclashes
ViktorHofer Mar 25, 2020
7b7ebf7
Downgrade compiler version
ViktorHofer Mar 25, 2020
e95e8e1
Upgrade Sdk.IL
ViktorHofer Mar 26, 2020
b54fed1
Fix Merge conflicts
ViktorHofer Mar 26, 2020
12457da
Update IL versions in Version.Details.xml
ViktorHofer Mar 26, 2020
a3d014a
Move ToolRuntimeRID usage
ViktorHofer Mar 26, 2020
c5a4d8e
Fix typo in eng/build.sh
ViktorHofer Mar 26, 2020
1d27de8
Fix Newtonsoft packagerefs
ViktorHofer Mar 26, 2020
9be2b6d
Add missing json ref
ViktorHofer Mar 26, 2020
7c64e58
Fix M.E.C.UserSecretes.Tests references
ViktorHofer Mar 27, 2020
6eff600
Rename libraries tests subset to distinguish
ViktorHofer Mar 27, 2020
2450615
Use entrypoint Build.proj file
ViktorHofer Mar 27, 2020
b53bfac
Fixes to make this build
ViktorHofer Mar 30, 2020
fff169e
Fix mono build
ViktorHofer Mar 30, 2020
3f3c38e
Fix mono restore by sequencing correctly
ViktorHofer Mar 31, 2020
7eb7c9b
Fix ordering of subsets
ViktorHofer Mar 31, 2020
b6e8d46
Remove outdated package doc section
ViktorHofer Mar 31, 2020
3bb72d9
Build fixes and other nits
ViktorHofer Mar 31, 2020
1467d42
Fix overlapping libraries test subset name
ViktorHofer Mar 31, 2020
a69fe7c
Fix enterprise build
ViktorHofer Mar 31, 2020
bb070c1
Generate RuntimeOSPropsFile correctly via sdk task
ViktorHofer Apr 1, 2020
4e2a5f2
React to Extensions proj and harvesting fix
ViktorHofer Apr 1, 2020
c827bd7
Update .gitignore
ViktorHofer Apr 1, 2020
2a4fca8
PR feedback
ViktorHofer Apr 1, 2020
071c2ad
Erics PR feedback and delete nit
ViktorHofer Apr 1, 2020
a2fd1f8
Revert deletion and rename file
ViktorHofer Apr 1, 2020
3ce089d
Fix ApiCompat invocation
ViktorHofer Apr 2, 2020
7f810fb
Cleanup prop for shims
ViktorHofer Apr 2, 2020
3c6c300
Move ILLink PackageRef into illink.targets and condition
ViktorHofer Apr 2, 2020
65aa3e2
Revert packageref conditions
ViktorHofer Apr 2, 2020
015f000
Remove implicit packageref
ViktorHofer Apr 2, 2020
a5712c5
Generate runtimeprops only once
ViktorHofer Apr 2, 2020
cbdd24d
Avoid binclashes of external projects
ViktorHofer Apr 2, 2020
f3508fa
Replace manual pretest invocation with subset
ViktorHofer Apr 2, 2020
c50661c
Fix run-test-job yml
ViktorHofer Apr 2, 2020
2e071df
PR feedback and fix
ViktorHofer Apr 2, 2020
c7f8492
Disable netstandard.depproj in installer
ViktorHofer Apr 2, 2020
352a8c3
Sequence runtime.depproj into pretest
ViktorHofer Apr 2, 2020
384bc8d
Sequence depprojs correctly
ViktorHofer Apr 2, 2020
7012d4c
Fix pretest build sequencing
ViktorHofer Apr 2, 2020
45cb54e
Avoid binclashes with netstandard.*proj
ViktorHofer Apr 3, 2020
6a8bc91
Disable netstandard ref pack for real
ViktorHofer Apr 3, 2020
51a64f3
Add pretest subset to build-test-job
ViktorHofer Apr 3, 2020
cdb4e84
Fix parallel settings for installer projects
ViktorHofer Apr 3, 2020
ba0aabd
Finally found the installer bug
ViktorHofer Apr 3, 2020
08cdc91
Fix packaging UsingTask element
ViktorHofer Apr 4, 2020
a4bdf5a
Add Json Package dependency
ViktorHofer Apr 4, 2020
4a4b12a
Fix ordering of pack vs test targets for libs
ViktorHofer Apr 4, 2020
6dd172e
Include pretest always
ViktorHofer Apr 4, 2020
ecc4135
Revert GenerateDependencyFile change in DependencyModel
ViktorHofer Apr 4, 2020
321e181
Remove unused launchsettings target
ViktorHofer Apr 4, 2020
c14fb29
Remove json dependency
ViktorHofer Apr 4, 2020
4c0c75e
Upgrade Newtonsoft.Json's version in DependencyModel
ViktorHofer Apr 4, 2020
3acad7e
Upgrade SDK version to latest
ViktorHofer Apr 4, 2020
2793329
Downgrade sdk version for UseDotnet@2 to work
ViktorHofer Apr 4, 2020
97fd77a
Pin sdk for internal tools restore
ViktorHofer Apr 4, 2020
f98eb05
Upgrade sdk to a recognized version
ViktorHofer Apr 4, 2020
ffbd49d
Downgrade sdk again
ViktorHofer Apr 4, 2020
49c2a31
Only copy packages dir if exists
ViktorHofer Apr 4, 2020
ed4d997
Avoid binclash for netcoreapp.depproj
ViktorHofer Apr 4, 2020
d225556
Use non static graph restore for depprojs
ViktorHofer Apr 4, 2020
12466f2
Exlude depproj and pkgproj installer static graph restore
ViktorHofer Apr 5, 2020
8350cbb
Fix packaging reports
ViktorHofer Apr 5, 2020
16f2663
Avoid races in restore
ViktorHofer Apr 5, 2020
48c6696
Move installer bundle to non static graph restore
ViktorHofer Apr 6, 2020
7e01783
Disable static graph restore in installer pkgs
ViktorHofer Apr 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pretest build sequencing
  • Loading branch information
ViktorHofer committed Apr 4, 2020
commit 7012d4c3ebce6991b8228987061fc3a7cbcb16ac
19 changes: 15 additions & 4 deletions src/libraries/pretest.proj
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,24 @@
<TraversalGlobalProperties>BuildAllProjects=true</TraversalGlobalProperties>
</PropertyGroup>

<!-- Explicitly build the runtime.depproj project first to correctly set up the testhost. -->
<ItemGroup>
<RuntimeProject Include="restore\runtime\runtime.depproj" />
<ProjectReference Include="@(RuntimeProject)" Condition="'$(MSBuildRestoreSessionId)' != ''" />
</ItemGroup>

<ItemGroup>
<!-- Explicitly include the runtime.depproj project here to correctly set up the testhost. -->
<ProjectReference Include="restore\runtime\runtime.depproj" />
<!-- This is necessary as inside VS project references that aren't part of the sln aren't built. -->
<ProjectReference Include="$(CommonTestPath)CoreFx.Private.TestUtilities\CoreFx.Private.TestUtilities.csproj" />
</ItemGroup>

<Target Name="RestoreTestHost"
BeforeTargets="Build">
<MSBuild Targets="Build"
Projects="@(RuntimeProject)"
Properties="$(TraversalGlobalProperties)" />
</Target>

<!-- Microsoft.XmlSerializer.Generator should not be marked as a platform item and be copy-local instead. -->
<Target Name="CollectSharedFrameworkRuntimeFiles"
Condition="'$(PlatformManifestFile)' != '' and '$(BuildingNETCoreAppVertical)' == 'true'">
Expand All @@ -30,7 +41,7 @@
<Target Name="GenerateFileVersionProps"
DependsOnTargets="CollectSharedFrameworkRuntimeFiles"
Condition="'$(PlatformManifestFile)' != '' and '$(BuildTargetFramework)' == '$(NetCoreAppCurrent)'"
AfterTargets="Build">
AfterTargets="RestoreTestHost">
<GenerateFileVersionProps Files="@(SharedFrameworkRuntimeFiles)"
PackageId="Microsoft.NETCore.App"
PackageVersion="$(ProductVersion)"
Expand All @@ -47,7 +58,7 @@
<UsingTask TaskName="GenerateTestSharedFrameworkDepsFile" AssemblyFile="$(InstallerTasksAssemblyPath)"/>
<Target Name="GenerateTestSharedFrameworkDepsFile"
Condition="'$(BinplaceTestSharedFramework)' == 'true' and '$(BuildTargetFramework)' == '$(NetCoreAppCurrent)'"
AfterTargets="Build">
AfterTargets="RestoreTestHost">
<GenerateTestSharedFrameworkDepsFile SharedFrameworkDirectory="$(NETCoreAppTestSharedFrameworkPath)"
RuntimeGraphFiles="$(RuntimeIdGraphDefinitionFile)"
TargetRuntimeIdentifier="$(PackageRID)" />
Expand Down