Skip to content

GC coverage can now occur in scenarios where a thread doesn't exist. #33615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 5 commits into from
Mar 17, 2020
Merged

GC coverage can now occur in scenarios where a thread doesn't exist. #33615

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8570bc9
GC coverage can now occur in scenarios where a thread doesn't exist.
AaronRobinsonMSFT Mar 16, 2020
3564b03
Update gccover.cpp
AaronRobinsonMSFT Mar 16, 2020
33378a7
Remove MethodDesc from GC coverage.
AaronRobinsonMSFT Mar 16, 2020
d6989bd
Code review and fix some asserts when running the Debug version of te…
AaronRobinsonMSFT Mar 16, 2020
ee53fec
Limit JIT flag manipulation to FEATURE_TIERED_COMPILATION
AaronRobinsonMSFT Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove MethodDesc from GC coverage.
  • Loading branch information
@AaronRobinsonMSFT
AaronRobinsonMSFT committed Mar 16, 2020
commit 33378a7ab15face3ef8e510a5c07a5d513ea0590
3 changes: 2 additions & 1 deletion src/coreclr/src/vm/gccover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,8 @@ BOOL OnGcCoverageInterrupt(PCONTEXT regs)
// where the call could be coming from a thread unknown to the CLR and
// we haven't created a thread yet - see PreStubWorker_Preemptive().
_ASSERTE(pMD->HasNativeCallableAttribute());
return (FALSE);
RemoveGcCoverageInterrupt(instrPtr, savedInstrPtr);
return TRUE;
}

#if defined(USE_REDIRECT_FOR_GCSTRESS) && !defined(TARGET_UNIX)
Expand Down