Handle CriticalExtensions and WeakSignature on 509Chain for macOS #35548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a certificate contains an unprocessable critical extension in a certificate, map the "CriticalExtensions" status to HasNotSupportedCriticalExtension instead of throwing an exception.
X509Chain on Windows will not check for modern signatures, so we will let macOS do the same thing.
Member
Author
|
@bartonjs random thought: the unit tests written for these macOS cert building statuses make decent use of the What's the best way to move forward with porting these fixes to corefx? |
bartonjs
approved these changes
Apr 28, 2020
Member
|
The tests that can't be backported because they require new features can just be left out; and that'll just be a comment in the servicing paperwork. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves two more unmapped chain status issues with macOS.
Fixes #35533
Fixes #35492