Fix Path.GetPathRoot wrong check in Unix #35734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @jozkee |
jkotas
reviewed
May 2, 2020
src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 2, 2020
src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 2, 2020
src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests_Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 2, 2020
src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
May 2, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
The product fix looks good. I agree with Jan about fixing the test.
jkotas
reviewed
May 3, 2020
src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests_Unix.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35260
The first element in the condition of the conditional operator was wrong: We should return null if the passed path is effectively empty. I made sure the structure looked just like in the other method overload, to avoid confusion.
I added one unit test to verify the particular case in which I found the bug. In my PR for redundant segments I will be adding many more since GetPathRoot is used by the new API.