Skip to content

[mono] Enable some System.Reflection.Emit tests #35872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexischr merged 1 commit into from
May 16, 2020
Merged

[mono] Enable some System.Reflection.Emit tests #35872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ namespace System.Reflection.Emit.Tests
public class ConstructorBuilderToString
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)]
public void ToString_NullRequiredOptionalCustomModifiers()
{
TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public);
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ public void DefineEnum_VoidUnderlyingType_ThrowsArgumentException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)]
public void DefineEnum_ByRefUnderlyingType_ThrowsCOMExceptionOnCreation()
{
ModuleBuilder module = Helpers.DynamicModule();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public static IEnumerable<object[]> TestData()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)]
[MemberData(nameof(TestData))]
public void DefineType(string name, TypeAttributes attributes, Type parent, PackingSize packingSize, int typesize, Type[] implementedInterfaces)
{
Expand Down
2 changes: 1 addition & 1 deletion ...mono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorBuilder.Mono.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public override Module Module

public override string ToString()
{
return "ConstructorBuilder ['" + type.Name + "']";
return "Name: " + Name;
Copy link
Member

@stephentoub stephentoub May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coreclr's ends up doing a bit more than this: it delegates to m_methodBuilder.ToString(), which prints out Name, Attributes, and MethodSignature. Should this do the same?

Copy link
Contributor Author

@alexischr alexischr May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I'll do that

Copy link
Contributor Author

@alexischr alexischr May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub Since we don't use a methodbuilder here in Mono, this complicated to do right after all. I can remove this change from the PR that's just supposed to enable tests, or I can leave it in as at least an improvement. What do you think?

Copy link
Member

@stephentoub stephentoub May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either's fine. Might be worth tracking the known difference in an issue, but up to you. Thanks.

}

internal void fixup()
Expand Down