Skip to content

Refactor HasMultiRegRetVal and impFixupCallStructReturn. #36465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandreenko merged 9 commits into from
May 15, 2020
Merged

Refactor HasMultiRegRetVal and impFixupCallStructReturn. #36465

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
93e5224
Fix target definitions.
May 6, 2020
9d1acfd
Fix failures after a recent HW changes.
May 7, 2020
bb8cab8
Add a const getter for `ReturnTypeDesc` from a call.
May 14, 2020
2a7647f
Refactor `HasMultiRegRetVal` and `impFixupCallStructReturn`.
May 14, 2020
7856087
Delete an extra `.` in some dumps.
May 14, 2020
81dda67
Add an additional check that `ReturnTypeDesc` is initialized.
May 14, 2020
25b005b
Remove old `const_cast` around `GetReturnTypeDesc`.
May 14, 2020
82ee494
Replace non-const `GetReturnTypeDesc` with other methods.
May 15, 2020
1bdda32
Fix uninitialized `gtSpillFlags, gtOtherRegs, gtReturnTypeDesc` in `f…
May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix failures after a recent HW changes.
  • Loading branch information
Sergey Andreenko committed May 8, 2020
commit 9d1acfd5953dcd07e6622dd23873fffca8675b1c
5 changes: 5 additions & 0 deletions src/coreclr/src/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3057,7 +3057,12 @@ void Lowering::LowerRetStruct(GenTreeUnOp* ret)
LowerRetStructLclVar(ret);
break;

#ifdef FEATURE_SIMD
case GT_SIMD:
#endif // FEATURE_SIMD
#ifdef FEATURE_HW_INTRINSICS
case GT_HWINTRINSIC:
Copy link
Member

@tannergooding tannergooding May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a case introduced by the move of some GT_SIMD intrinsics to be GT_HWINTRINSIC?

(Just want to understand if its a case I missed and where the error was raised so I can check it next time... 😄)

Copy link
Contributor Author

@sandreenko sandreenko May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it was happening only with JitOldStructRetyping=0 that is disabled by default.

#endif // FEATURE_HW_INTRINSICS
case GT_LCL_FLD:
{
GenTreeUnOp* bitcast = new (comp, GT_BITCAST) GenTreeOp(GT_BITCAST, ret->TypeGet(), retVal, nullptr);
Expand Down