Use nint instead of IntPtr in _RegisterFrozenSegment.

[eerhardt]

No description provided.

[jkotas]

What is motivating this?

[jkotas]

I mean there are hundreds (or even more) places that can use a cleanup like this. I am wondering why you have picked this one.

[eerhardt]

What is motivating this?
I mean there are hundreds (or even more) places that can use a cleanup like this. I am wondering why you have picked this one.

I was looking through all the places where we are rooting methods/types for the linker:

https://github.com/dotnet/runtime/blob/master/src/coreclr/src/System.Private.CoreLib/ILLinkTrim.xml

And I noticed this one and thought it would take 5 minutes to send a PR to make the code better.

[mjsabby]

I haven't been following the nint thing, does this still put System.IntPtr in the metadata?

[eerhardt]

does this still put System.IntPtr in the metadata?

Yes. You can read more about the underlying design of nint here, if you are interested.

[ghost]

Tagging subscribers to this area: @Maoni0
Notify danmosemsft if you want to be subscribed.

[jkotas]

The unmanaged size is using unsigned type for this, but fixing that would require changes in the code that looks up this API via private reflection.

[eerhardt]

Right - the unmanaged code is using SIZE_T.

runtime/src/coreclr/src/vm/comutilnative.cpp

Lines 1127 to 1133 in ab49e0f

	/*===============================RegisterFrozenSegment===============================
	**Action: Registers the frozen segment
	**Returns: segment_handle
	**Arguments: args-> pointer to section, size of section
	**Exceptions: None
	==============================================================================*/
	void* QCALLTYPE GCInterface::RegisterFrozenSegment(void* pSection, SIZE_T sizeSection)

I didn't want to actually change the managed type. Unless @mjsabby was OK with it. I assume that is the only user of this experimental feature, or are there others?

[danmoseley]

Oops, I merged this -- perhaps there was an open question here?