Skip to content

Conversation

@0xfk0
Copy link
Contributor

@0xfk0 0xfk0 commented May 27, 2020

This commit fixes broken build in case when following arguments added to
build.sh script: --cmakeargs -DFEATURE_GDBJIT=true

@alpencolt, @jkotas

This commit fixes broken build in case when following arguments added to
build.sh script: --cmakeargs -DFEATURE_GDBJIT=true
@ghost
Copy link

ghost commented May 27, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@0xfk0
Copy link
Contributor Author

0xfk0 commented May 27, 2020

Without this fix following error occurs:

  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/vm/ceemain.cpp:119:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/vm/crossgen/../common.h:97:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/stdmacros.h:22:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/contract.h:254:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/check.h:725:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/check.inl:9:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/clrhost.h:19:
  /home/sysop/dotnet-runtime/src/coreclr/src/inc/holder.h:1016:5: error: deleting pointer to incomplete type 'Elf_Symbol' may cause undefined behavior [-Werror,-Wdelete-incomplete]
      delete [] value;
      ^         ~~~~~
  /home/sysop/dotnet-runtime/src/coreclr/src/inc/holder.h:1021:50: note: in instantiation of function template specialization 'DeleteArray<Elf_Symbol>' requested here
  using NewArrayHolder = SpecializedWrapper<_TYPE, DeleteArray<_TYPE>>;
                                                   ^
  /home/sysop/dotnet-runtime/src/coreclr/src/vm/crossgen/../gdbjit.h:337:8: note: forward declaration of 'Elf_Symbol'
  struct Elf_Symbol;
         ^
  1 error generated.
  Stripping symbols from $<TARGET_FILE:clrjit> into file $<TARGET_FILE:clrjit>.dbg
  src/vm/crossgen/CMakeFiles/cee_crossgen.dir/build.make:179: recipe for target 'src/vm/crossgen/CMakeFiles/cee_crossgen.dir/__/ceemain.cpp.o' failed
  make[2]: *** [src/vm/crossgen/CMakeFiles/cee_crossgen.dir/__/ceemain.cpp.o] Error 1
  CMakeFiles/Makefile2:4291: recipe for target 'src/vm/crossgen/CMakeFiles/cee_crossgen.dir/all' failed
  make[1]: *** [src/vm/crossgen/CMakeFiles/cee_crossgen.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/vm/prestub.cpp:14:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/vm/common.h:97:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/stdmacros.h:22:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/contract.h:254:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/check.h:725:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/check.inl:9:
  In file included from /home/sysop/dotnet-runtime/src/coreclr/src/inc/clrhost.h:19:
  /home/sysop/dotnet-runtime/src/coreclr/src/inc/holder.h:1016:5: error: deleting pointer to incomplete type 'Elf_Symbol' may cause undefined behavior [-Werror,-Wdelete-incomplete]
      delete [] value;
      ^         ~~~~~
  /home/sysop/dotnet-runtime/src/coreclr/src/inc/holder.h:1021:50: note: in instantiation of function template specialization 'DeleteArray<Elf_Symbol>' requested here
  using NewArrayHolder = SpecializedWrapper<_TYPE, DeleteArray<_TYPE>>;
                                                   ^
  /home/sysop/dotnet-runtime/src/coreclr/src/vm/gdbjit.h:337:8: note: forward declaration of 'Elf_Symbol'
  struct Elf_Symbol;
         ^
  1 error generated.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit a890e65 into dotnet:master May 27, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants