Skip to content

Disable JitDoOldStructRetyping by default. #37745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandreenko merged 10 commits into from
Jul 7, 2020
Merged

Disable JitDoOldStructRetyping by default. #37745

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f432437
Disable retyping by default.
Jun 9, 2020
06e7c52
Keep block init/copy as baseline.
Jun 13, 2020
f53bb30
Don't mark LCL_VAR that is used in RETURN(IND(ADDR(LCL_VAR)) as addre…
Jun 10, 2020
3965e9d
Replace 1-field structs with the field for returns.
Jun 21, 2020
f7a90a3
Add SSA support.
Jun 22, 2020
8911b08
Review response.
Jul 2, 2020
0d8cf17
isOpaqueSIMDLclVar fix
Jul 3, 2020
c16fc9f
Add tests for structs with independently promoted SIMD fields.
Jul 7, 2020
e0fbd5f
Old retyping fix.
Jul 7, 2020
9daf9c1
Don't try to replace SIMD fields.
Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't try to replace SIMD fields.
  • Loading branch information
Sergey Andreenko committed Jul 7, 2020
commit 9daf9c1e9db930195a50c4f81d92285a43244e35
10 changes: 1 addition & 9 deletions src/coreclr/src/jit/lclvars.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3684,17 +3684,9 @@ bool LclVarDsc::CanBeReplacedWithItsField(Compiler* comp) const
// In order to do that we have to have its field `a` in memory. Right now lowering cannot
// handle RETURN struct(multiple registers)->SIMD16(one register), but it can be improved.
LclVarDsc* fieldDsc = comp->lvaGetDesc(lvFieldLclStart);
if (fieldDsc->TypeGet() == TYP_SIMD12 || fieldDsc->TypeGet() == TYP_SIMD16)
if (varTypeIsSIMD(fieldDsc))
{
#if defined(TARGET_ARM64)
if (!comp->isOpaqueSIMDLclVar(fieldDsc))
{
return false;
}
#else // !TARGET_ARM64
// TODO-X64-CQ: check for `isOpaqueSIMDLclVar` after https://github.com/dotnet/runtime/issues/9578.
return false;
#endif //! TARGET_ARM64
}
#endif // FEATURE_SIMD

Expand Down