Skip to content

ICU integration and asset loading overhaul #37971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kg merged 68 commits into from
Jul 16, 2020
Merged

ICU integration and asset loading overhaul #37971

Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
cbae5e5
initial static ICU implementation for wasm
EgorBo Jun 17, 2020
f9fc4e3
Update pal_icushim_internal.h
EgorBo Jun 17, 2020
bdc8955
Checkpoint
kg Jun 12, 2020
b3e2325
Add stubs for tz and calendar, enable tests
EgorBo Jul 2, 2020
ca35363
Update System.Private.CoreLib.Shared.projitems
EgorBo Jul 2, 2020
0659c74
Merge branch 'master' of github.com:dotnet/runtime into icu-loader
EgorBo Jul 10, 2020
72078b9
Fix EnumCalendarInfo for wasm (temp workaround)
EgorBo Jul 10, 2020
04993e8
Merge branch 'master' of github.com:dotnet/runtime into icu-loader-egor2
EgorBo Jul 13, 2020
901c499
cccc
EgorBo Jul 13, 2020
bf6587a
Fix small issues
EgorBo Jul 13, 2020
39c315a
drop ICU_REPO
EgorBo Jul 13, 2020
7c1855a
Update Program.cs
EgorBo Jul 13, 2020
e2a57ff
clean up
EgorBo Jul 13, 2020
f77ad54
Update tests.proj
EgorBo Jul 13, 2020
529e8e1
Update Program.cs
EgorBo Jul 13, 2020
c0fb094
Update tests.proj
EgorBo Jul 13, 2020
9698771
Checkpoint
kg Jul 14, 2020
6d5494a
Checkpoint
kg Jul 14, 2020
632d1fa
Checkpoint
kg Jul 14, 2020
99b64a0
Checkpoint
kg Jul 14, 2020
73e7ec3
Checkpoint
kg Jul 14, 2020
857cd9b
Fix formatting error
kg Jul 14, 2020
858a2af
Checkpoint
kg Jul 14, 2020
5ff4030
Checkpoint
kg Jul 14, 2020
df66deb
bump ICU nuget, skip some tests
EgorBo Jul 15, 2020
fea9e1b
Merge branch 'icu-loader' of github.com:kg/runtime into icu-loader
EgorBo Jul 15, 2020
bf979b3
Checkpoint
kg Jul 14, 2020
4872ae4
Fix whitespace
kg Jul 14, 2020
ec10683
Checkpoint
kg Jul 15, 2020
7ec82a8
Checkpoint
kg Jul 15, 2020
301b1e6
Address PR feedback, cleanup whitespace
kg Jul 15, 2020
563e985
Remove testing fallback URL
kg Jul 15, 2020
1a5f206
Switch back to using u_init because getCLDRVersion is broken.
kg Jul 15, 2020
a64b46a
Implement get_loaded_files
kg Jul 15, 2020
ea40744
Make loader diagnostic messages optional and off by default
kg Jul 15, 2020
642d35f
Also silence the loaded assets dict
kg Jul 15, 2020
960ebf0
Apply tracing flag to vfs logs as well
kg Jul 15, 2020
cb5c2b2
Merge branch 'master' of github.com:dotnet/runtime into icu-loader
EgorBo Jul 15, 2020
54401b4
ulocdata_getCLDRVersion works with new ICU nuget
EgorBo Jul 15, 2020
e6faed4
Merge branch 'master' of github.com:dotnet/runtime into icu-loader
EgorBo Jul 15, 2020
7f904dc
Update RegionInfoTests.cs
EgorBo Jul 15, 2020
5dbe40b
Update pal_icushim_internal.h
EgorBo Jul 15, 2020
5544389
Make sure the VFS files have write permissions
akoeplinger Jul 15, 2020
88a776a
Address feedback
EgorBo Jul 15, 2020
30af86f
Disable two tests in System.Runtime.Extensions
EgorBo Jul 15, 2020
801b95e
Add satellite assemblies to VFS
akoeplinger Jul 15, 2020
c06c63b
EnglishName_TestData is back to normal for ICU
EgorBo Jul 15, 2020
2e4ed37
Create and populate MONO.loaded_files
kg Jul 15, 2020
855b840
Add icu data file to runtimepack
akoeplinger Jul 15, 2020
4ea64d9
Adjust public interface for various bits of setup
kg Jul 15, 2020
3fb2ec9
Add compatibility shim for runtime_and_bcl, export some APIs
kg Jul 15, 2020
da89834
Remove now-broken ICUDataFiles parameter from csproj
kg Jul 15, 2020
4ac3230
Fix spurious ICU load error
kg Jul 15, 2020
279ec28
Store asset URLs into loaded_files instead of names
kg Jul 15, 2020
23ea27c
Address feedback
EgorBo Jul 15, 2020
cafd0f2
Update src/libraries/Common/src/Interop/Interop.TimeZoneInfo.Browser.cs
lewing Jul 16, 2020
c95ad39
Merge remote-tracking branch 'upstream/master' into icu-loader
kg Jul 16, 2020
3eaa5fb
Revert sample changes
kg Jul 16, 2020
794e290
Update src/libraries/Native/Unix/System.Globalization.Native/pal_icus…
kg Jul 16, 2020
34867d7
enable NativeCalendarName and RegionInfo.NativeName tests for wasm
EgorBo Jul 16, 2020
fe0e686
Update Version.Details.xml
EgorBo Jul 16, 2020
9b20a78
bump ICU
EgorBo Jul 16, 2020
49097be
Address feedback
EgorBo Jul 16, 2020
adc967e
Update Interop.TimeZoneInfo.Browser.cs
EgorBo Jul 16, 2020
6cf61e0
Address feedback
EgorBo Jul 16, 2020
eff92b4
Address feedback
EgorBo Jul 16, 2020
7a1a28e
ignore Interop.TimeZoneInfo on wasm
EgorBo Jul 16, 2020
d64d256
Address feedback
EgorBo Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Interop.TimeZoneInfo.Browser.cs
  • Loading branch information
@EgorBo
EgorBo committed Jul 16, 2020
commit adc967eb02ef5498ebfc98dc79d0f661f9f987a4
1 change: 0 additions & 1 deletion src/libraries/Common/src/Interop/Interop.TimeZoneInfo.Browser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Runtime.InteropServices;

Expand Down