Skip to content

AdvSimd support for System.Text.Unicode.Utf8Utility.GetPointerToFirstInvalidByte #38653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 19 commits into from
Jul 20, 2020
Merged

AdvSimd support for System.Text.Unicode.Utf8Utility.GetPointerToFirstInvalidByte #38653

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
38e528b
AdvSimd support for System.Text.Unicode.Utf8Utility.GetPointerToFirst…
carlossanlop Jul 1, 2020
db7a4b1
Move comment to the top, add shims.
carlossanlop Jul 1, 2020
3daf5cc
Little endian checks
carlossanlop Jul 1, 2020
3fb9b55
Use custom MoveMask method for AdvSimd
carlossanlop Jul 10, 2020
3a340b7
Address suggestions to improve the AdvSimdMoveMask method
carlossanlop Jul 10, 2020
45bb8dd
Define initialMask outside MoveMask method
carlossanlop Jul 10, 2020
d4e5497
UInt64 in Arm64MoveMask
carlossanlop Jul 13, 2020
d761124
Add unit test case to verify intrinsics improvement
carlossanlop Jul 14, 2020
af42e59
Avoid casting to smaller integer type
carlossanlop Jul 14, 2020
bb07819
Typo and comment
carlossanlop Jul 14, 2020
55dd236
Use ShiftRightArithmetic instead of CompareEqual + And.
carlossanlop Jul 14, 2020
46bbf26
Use AddPairwise version of GetNotAsciiBytes
carlossanlop Jul 14, 2020
6f4cca9
Add missing shims causing Linux build to fail
carlossanlop Jul 15, 2020
b2d3705
Simplify GetNonAsciiBytes to only one AddPairwise call, shorter bitmask
carlossanlop Jul 16, 2020
8536a8d
Respect data type returned by masking method
carlossanlop Jul 16, 2020
a45fe16
Address suggestions - assert trailingzerocount and bring back uint mask
carlossanlop Jul 17, 2020
b09e92c
Trailing zeroes in AdvSimd need to be divided by 4, and total number …
carlossanlop Jul 17, 2020
5c3cee2
Avoid declaring static field which causes PNSE in Utf8String.Experime…
carlossanlop Jul 17, 2020
d9dd878
Prefer using nuint for BitConverter.TrailingZeroCount
carlossanlop Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address suggestions - assert trailingzerocount and bring back uint mask
  • Loading branch information
@carlossanlop
carlossanlop committed Jul 17, 2020
commit a45fe16a26bbac791542fc0a47365888ec913b5b
4 changes: 3 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Validation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,14 @@ internal static unsafe partial class Utf8Utility
if (mask != 0)
{
trailingZeroCount = BitOperations.TrailingZeroCount(mask);
Debug.Assert(trailingZeroCount < 16);

goto LoopTerminatedEarlyDueToNonAsciiData;
}
}
else if (Sse2.IsSupported)
{
int mask = Sse2.MoveMask(Sse2.LoadVector128(pInputBuffer));
uint mask = (uint)Sse2.MoveMask(Sse2.LoadVector128(pInputBuffer));
if (mask != 0)
{
trailingZeroCount = BitOperations.TrailingZeroCount(mask);
Expand Down