Fix handling of native runtime components for Crossgen2 package #38788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Jul 5, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amendment to #38600. I figured out that the issue was caused by appending a trailing slash to TargetPath in netcoreapp.depproj file in #36781: https://github.com/dotnet/runtime/pull/36781/files#diff-9fac0b3c275ca346bd7e392f9ae3807cL108-R108, which made the native libraries to be omitted by the following line in Microsoft.NETCore.App.Crossgen2.pkgproj:
The changes in this PR remove the trailing slash and exclude static
.alibraries, which are not used by Crossgen2. @dotnet/crossgen-contrib