Skip to content

add OSPlatform.macOS, make OSPlatform.Equal use OrdinalIgnoreCaseComparison #39064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 11 commits into from
Closed

add OSPlatform.macOS, make OSPlatform.Equal use OrdinalIgnoreCaseComparison #39064

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5909ffe
introduce new OSPlatforms
adamsitnik Jul 10, 2020
d586408
use OrdinalIgnoreCase instead of Ordinal for os platform name compari…
adamsitnik Jul 10, 2020
76783a6
hide OSX, make sure OSX == macOS
adamsitnik Jul 10, 2020
2d2ed3e
add more tests
adamsitnik Jul 10, 2020
f388f03
Merge remote-tracking branch 'upstream/master' into 33331newOsPlatforms
adamsitnik Jul 10, 2020
7a8f548
simplify the code based on ideas from code review
adamsitnik Jul 10, 2020
8a3277e
add more test cases
adamsitnik Jul 10, 2020
d3e751d
add suggested test cases
adamsitnik Jul 10, 2020
8ae72cf
address code review feedback
adamsitnik Jul 10, 2020
f3c439a
fix a bug that I've introduced
adamsitnik Jul 10, 2020
84d959a
use StringComparison.OrdinalIgnoreCase in GetHashCode as well
adamsitnik Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more tests
  • Loading branch information
@adamsitnik
adamsitnik committed Jul 10, 2020
commit 2d2ed3e5eaedbf6b20717d055c0ae0c33d0eea6e
48 changes: 48 additions & 0 deletions src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/CheckPlatformTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,54 @@ public void CheckOSX()
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.watchOS));
}

[Fact, PlatformSpecific(TestPlatforms.Android)]
public void CheckAndroid()
{
Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.Android));

Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.OSX));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.macOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Linux));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Windows));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.FreeBSD));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Browser));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.iOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.tvOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.watchOS));
}

[Fact, PlatformSpecific(TestPlatforms.tvOS)]
public void Check_tvOS()
{
Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.tvOS));

Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.OSX));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.macOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Linux));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Windows));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.FreeBSD));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Browser));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Android));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.iOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.watchOS));
}

[Fact, PlatformSpecific(TestPlatforms.iOS)]
public void Check_iOS()
{
Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.iOS));

Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.OSX));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.macOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Linux));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Windows));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.FreeBSD));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Browser));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.Android));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.tvOS));
Assert.False(RuntimeInformation.IsOSPlatform(OSPlatform.watchOS));
}

[Fact, PlatformSpecific(TestPlatforms.Windows)] // Tests RuntimeInformation OS platform
public void CheckWindows()
{
Expand Down