-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[browser][wasm] Configuring request options in Browser WebAssembly #39182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f47ccd3
[browser][wasm] Initial addition of configuring request options in Br…
kjpou1 29a208e
Fix key code. Not what was proposed
kjpou1 64e8227
Add TryGetValue<TValue> and Set<TValue> as per proposal
kjpou1 23f0207
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 b0e55ee
Add missing obsolete attribute
kjpou1 d22d482
Address review comments
kjpou1 4739203
Update tests to use Options and not obsolete Properties.
kjpou1 7101065
Implement IDictionary<string, object?> explicitly
kjpou1 1056cdc
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 8886161
Update tests to use Options and not obsolete Properties.
kjpou1 f62bc16
Add HttpRequestOptions source to the System.Net.Http.Unit.Tests proje…
kjpou1 44929fd
Address review comments - explicit
kjpou1 478bca6
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 8098c0e
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 3d5d7fa
Fix build error cannot convert from 'string' to 'System.Net.Http.Http…
kjpou1 7398927
Add tests for HttpRequestOptions
kjpou1 ea78e61
Fix test build
kjpou1 d6b49c5
Add special case code for NETFRAMEWORK for API change.
kjpou1 1b5683e
#endif out of place fix
kjpou1 23f1bc8
#endif out of place fix
kjpou1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
[browser][wasm] Initial addition of configuring request options in Br…
…owser WebAssembly
- Loading branch information
commit f47ccd3f72d86a12dd823a2b698f037b4ec30a2e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestOptions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace System.Net.Http | ||
| { | ||
| public sealed class HttpRequestOptions : Dictionary<HttpRequestOptionsKey<string>, object?> { } | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestOptionsKey.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
|
|
||
| namespace System.Net.Http | ||
| { | ||
| public readonly struct HttpRequestOptionsKey<TKey> | ||
| { | ||
| private readonly TKey _key; | ||
| public HttpRequestOptionsKey(TKey key) | ||
| { | ||
| _key = key; | ||
| } | ||
| public TKey Key => _key; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.