Skip to content

Narrow four utf16 chars to ascii and write to buffer #39508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgovind merged 6 commits into from
Jul 29, 2020
Merged

Narrow four utf16 chars to ascii and write to buffer #39508

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a6d145
Shims
Jul 17, 2020
fc0fee6
shim
Jul 20, 2020
3e5ced8
Cherry-pick
Jul 20, 2020
b511d88
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
Jul 17, 2020
9c2b8a7
Address comments
Jul 20, 2020
938efce
Nit
Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
shim
  • Loading branch information
Prashanth Govindarajan committed Jul 28, 2020
commit fc0fee6bddf7c31ad2a31a78e9daefd416e74dc1
1 change: 1 addition & 0 deletions ...ibraries/System.Utf8String.Experimental/src/System/Runtime/Intrinsics/Intrinsics.Shims.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ internal static class Vector64
public static Vector64<uint> AsUInt32<T>(this Vector64<T> vector) where T : struct => throw new PlatformNotSupportedException();
public static Vector64<T> GetLower<T>(this Vector128<T> vector) where T : struct => throw new PlatformNotSupportedException();
Copy link
Author

@pgovind pgovind Jul 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not strictly needed for this PR, but all of these APIs will be needed in subsequent PRs. Let me know if you'd rather that I keep this clean.

public static Vector64<ulong> AsUInt64<T>(this Vector64<T> vector) where T : struct => throw new PlatformNotSupportedException();
public static Vector64<uint> AsUInt32<T>(this Vector64<T> vector) where T : struct => throw new PlatformNotSupportedException();
}
internal readonly struct Vector64<T>
where T : struct
Expand Down