Fix ILLink warnings for removed attributes when Debugger.IsSupported is false #40048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
requested review from
MichalStrehovsky,
jkotas,
layomia,
marek-safar and
vitek-karas
eerhardt
requested review from
EgorBo,
akoeplinger,
steveisok and
vargaz
as code owners
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
reviewed
Jul 28, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/TraceLogging/Statics.cs
Outdated
Show resolved
Hide resolved
vargaz
reviewed
Jul 29, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs
Outdated
Show resolved
Hide resolved
…is false When Debugger.IsSupported feature switch is false, we trim unnecessary attributes in the code - specifically attributes like CompilerGeneratedAttribute and StackTraceHiddenAttribute. However, we still have code accessing these attributes, which causes the ILLinker to warn that it is removing the attributes, but code still uses them. To fix this, remove these attributes from being trimmed when Debugger.IsSupported is false. Instead these attributes will be preserved always so things like "is anonymous type" checks and stack trace tostring will behave correctly. Fix dotnet#39707
eerhardt
force-pushed
the
FixDebuggerAttributesWarning
branch
from
dd9809a to
751e24a
Compare
Member
Author
|
Thanks everyone for the feedback. I am now removing fyi - @marek-safar |
jkotas
approved these changes
Jul 30, 2020
Contributor
|
@eerhardt what is the negative size impact of this change for Blazor and how are we going to mitigate it? |
Member
Author
I am not sure it is necessary to mitigate it. 3 KB compressed is a pretty minimal change when the total compressed app size is around 2.2 MB. |
Member
Author
|
Test failures are #40178. I believe this is ready to merge. Any other feedback? |
MichalStrehovsky
approved these changes
Jul 31, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…is false (dotnet#40048) When Debugger.IsSupported feature switch is false, we trim unnecessary attributes in the code - specifically attributes like CompilerGeneratedAttribute and StackTraceHiddenAttribute. However, we still have code accessing these attributes, which causes the ILLinker to warn that it is removing the attributes, but code still uses them. To fix this, remove these attributes from being trimmed when Debugger.IsSupported is false. Instead these attributes will be preserved always so things like "is anonymous type" checks and stack trace tostring will behave correctly. Fix dotnet#39707
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Debugger.IsSupportedfeature switch is false, we trim unnecessary attributes in the code - specifically attributes likeCompilerGeneratedAttributeandStackTraceHiddenAttribute. However, we still have code accessing these attributes, which causes the ILLinker to warn that it is removing the attributes, but code still uses them.To fix this, remove these attributes from being trimmed when Debugger.IsSupported is false. Instead these attributes will be preserved always so things like "is anonymous type" checks and stack trace tostring will behave correctly.
Fix #39707