Skip to content

Do not test sockets handler fix on WinHttpHandler. #40070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManickaP merged 1 commit into from
Jul 29, 2020
Merged

Do not test sockets handler fix on WinHttpHandler. #40070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2119,7 +2119,7 @@ await server.AcceptConnectionAsync(async connection =>
[Fact]
public async Task SendAsync_Expect100Continue_RequestBodyFails_ThrowsContentException()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
if (IsWinHttpHandler)
{
return;
}
Expand All @@ -2137,7 +2137,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
HttpRequestMessage initialMessage = new HttpRequestMessage(HttpMethod.Post, uri) { Version = UseVersion };
initialMessage.Content = new ThrowingContent(() => new ThrowingContentException());
initialMessage.Headers.ExpectContinue = true;
Exception exception = await Assert.ThrowsAsync<ThrowingContentException>(() => client.SendAsync(TestAsync, initialMessage));
await Assert.ThrowsAsync<ThrowingContentException>(() => client.SendAsync(TestAsync, initialMessage));

clientFinished.SetResult(true);
}
Expand Down