Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Aug 1, 2020

No description provided.

@lewing lewing merged commit 1625943 into dotnet:master Aug 1, 2020
@lewing
Copy link
Member Author

lewing commented Aug 1, 2020

These are js changes that can't have impacted the failing CI lanes

@lewing lewing deleted the unused-bindings branch August 1, 2020 04:11
@midnight-dev
Copy link

I don't have any stake in this, just browsing a neat repository, so don't let me break your stride. But are there any tests in the pipeline that assume find_class & find_method exist or rely on the environment settings?

The GitHub android app does not have a convenient way to view CI results. Otherwise, I'd have taken a peak myself.

@lewing
Copy link
Member Author

lewing commented Aug 1, 2020

@midnight-dev the lanes that failed don't use the wasm js in any way. Additionally the methods that were removed are exposed and used from the runtime bindings where needed and don't need to be bound here.

@midnight-dev
Copy link

@lewing Roger. That satisfies my curiosity. Thanks for taking the time to respond. 👌

@danmoseley
Copy link
Member

@midnight-dev we have up for grabs issues if you're interested!

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants