Skip to content

Conversation

@safern
Copy link
Member

@safern safern commented Aug 6, 2020

Reverts #40299

This is causing System.Diagnostics.Process tests to crash in all Unix platforms with:

/private/tmp/helix/working/A5AE092E/w/A0C108D1/e /private/tmp/helix/working/A5AE092E/w/A0C108D1/e
  Discovering: System.Diagnostics.Process.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Diagnostics.Process.Tests (found 221 of 291 test cases)
  Starting:    System.Diagnostics.Process.Tests (parallel test collections = on, max threads = 4)
    System.Diagnostics.Tests.ProcessStartInfoTests.ShellExecute_Nano_Fails_Start [SKIP]
      Condition(s) not met: "IsWindowsNanoServer"
Darwin
/Users/runner/work/1/s/src/libraries/Native/Unix/System.Native/pal_process.c (665): error 0: Unknown signal (false failed)
Assertion failed: (false && "assert_msg failed"), function SystemNative_Kill, file /Users/runner/work/1/s/src/libraries/Native/Unix/System.Native/pal_process.c, line 665.
./RunTests.sh: line 161: 42789 Abort trap: 6           "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.Diagnostics.Process.Tests.runtimeconfig.json --depsfile System.Diagnostics.Process.Tests.deps.json xunit.console.dll System.Diagnostics.Process.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE

cc: @jkotas @Anipik

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@safern safern merged commit 0adf9b5 into master Aug 6, 2020
@safern safern deleted the revert-40299-mips_branch branch August 6, 2020 18:35
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants