Fix covariant override disassembly #40502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Aug 7, 2020
davidwrighton
commented
- This introduces a new path where ildasm must generate a full token description instead of relying on ilasm to produce the signature from the method body
- This introduces a new path where ildasm must generate a full token description instead of relying on ilasm to produce the signature from the method body
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
Member
Author
|
@janvorli FYI |
BruceForstall
approved these changes
Aug 7, 2020
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM. Probably should kick off a run of the round-trip test pipeline on this: https://dev.azure.com/dnceng/public/_build?definitionId=870
Member
|
so assume no changes are required to ILASM? |
Member
Author
|
@mangod9, no there aren't any required changes to ilasm that I can find. Also, unfortunately, in the general sense we can't produce good warnings. We could make it slightly better for overriding functions defined in the same module but that would be somewhat more complex and risky, and I do not believe it will provide value. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
- This introduces a new path where ildasm must generate a full token description instead of relying on ilasm to produce the signature from the method body
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.