Skip to content

Make the buffer size configurable for generational aware analysis #40918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cshung merged 1 commit into from
Aug 17, 2020
Merged

Make the buffer size configurable for generational aware analysis #40918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/coreclr/src/vm/eventpipe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "win32threadpool.h"
#include "ceemain.h"
#include "configuration.h"
#include "genanalysis.h"

#ifdef TARGET_UNIX
#include "pal.h"
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/src/vm/finalizerthread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#include "finalizerthread.h"
#include "threadsuspend.h"
#include "jithost.h"
#include "eventpipe.h"
#include "eventpipesession.h"
#include "genanalysis.h"

#ifdef FEATURE_COMINTEROP
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/src/vm/gcenv.ee.standalone.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

#include "gctoclreventsink.h"
#include "configuration.h"
#include "eventpipe.h"
#include "eventpipesession.h"
#include "genanalysis.h"

// the method table for the WeakReference class
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/src/vm/gcenv.ee.static.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

#include "gctoclreventsink.h"
#include "configuration.h"
#include "eventpipe.h"
#include "eventpipesession.h"
#include "genanalysis.h"

// the method table for the WeakReference class
Expand Down
4 changes: 3 additions & 1 deletion src/coreclr/src/vm/genanalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ GcGenAnalysisState gcGenAnalysisConfigured = GcGenAnalysisState::Uninitialized;
int64_t gcGenAnalysisGen = -1;
int64_t gcGenAnalysisBytes = 0;
int64_t gcGenAnalysisIndex = 0;
uint32_t gcGenAnalysisBufferMB = 0;

/* static */ void GenAnalysis::Initialize()
{
Expand All @@ -27,6 +28,7 @@ int64_t gcGenAnalysisIndex = 0;
{
gcGenAnalysisIndex = CLRConfig::GetConfigValue(CLRConfig::INTERNAL_GCGenAnalysisIndex);
gcGenAnalysisConfigured = GcGenAnalysisState::Enabled;
gcGenAnalysisBufferMB = CLRConfig::GetConfigValue(CLRConfig::INTERNAL_EventPipeCircularMB);
}
else
{
Expand Down Expand Up @@ -61,7 +63,7 @@ int64_t gcGenAnalysisIndex = 0;
pProviders[0] = EventPipeProviderConfiguration(W("Microsoft-Windows-DotNETRuntime"), keyword, 5, nullptr);
gcGenAnalysisEventPipeSessionId = EventPipe::Enable(
outputPath,
1024,
gcGenAnalysisBufferMB,
pProviders,
providerCnt,
EventPipeSessionType::File,
Expand Down