-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[Browser] Add mono_wasm_get_icudt_name API #41795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @CoffeeFlux |
src/libraries/Native/Unix/System.Globalization.Native/pal_icushim_static.c
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Globalization.Native/pal_icushim_static.c
Show resolved
Hide resolved
|
Why not store the name here: https://github.com/dotnet/runtime/blob/master/src/mono/wasm/runtime/library_mono.js#L1227 and return that directly from the JS instead of having to do the complication of checking the culture combinations? |
JS is not the only possible front-end to use static-ICU |
|
I see, makes sense. Thanks. |
|
/backport to release/5.0-rc2 |
lewing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the timing looks ok. In the future I think it would make sense to include a configuration file in the icu build that could be used to generate the lookup logic.
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/238102956 |
Motivation: dotnet/aspnetcore#25521 (comment)