Skip to content

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Sep 3, 2020

@ghost
Copy link

ghost commented Sep 3, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@EgorBo EgorBo added arch-wasm WebAssembly architecture and removed area-VM-meta-mono labels Sep 3, 2020
@EgorBo EgorBo marked this pull request as ready for review September 3, 2020 11:45
@EgorBo EgorBo requested a review from marek-safar as a code owner September 3, 2020 11:45
@ghost
Copy link

ghost commented Sep 3, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

@safern
Copy link
Member

safern commented Sep 3, 2020

Why not store the name here: https://github.com/dotnet/runtime/blob/master/src/mono/wasm/runtime/library_mono.js#L1227 and return that directly from the JS instead of having to do the complication of checking the culture combinations?

@EgorBo
Copy link
Member Author

EgorBo commented Sep 3, 2020

Why not store the name here: https://github.com/dotnet/runtime/blob/master/src/mono/wasm/runtime/library_mono.js#L1227 and return that directly from the JS instead of having to do the complication of checking the culture combinations?

JS is not the only possible front-end to use static-ICU

@safern
Copy link
Member

safern commented Sep 3, 2020

I see, makes sense. Thanks.

@marek-safar
Copy link
Contributor

/backport to release/5.0-rc2

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the timing looks ok. In the future I think it would make sense to include a configuration file in the icu build that could be used to generate the lookup logic.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2020

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/238102956

@EgorBo EgorBo merged commit 57c70c7 into dotnet:master Sep 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants