[release/5.0-rc2] Fix leaking ICorProfilerCallback10 #41833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
hoyosjs
approved these changes
Sep 4, 2020
sywhang
approved these changes
Sep 4, 2020
jeffschwMSFT
approved these changes
Sep 4, 2020
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. I will take it for consideration for RC2
danmoseley
added
Servicing-approved
Member
|
@jeffschwMSFT I guess this can be merged? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41791 to release/5.0-rc2
/cc @davmason @ww898
Customer Impact
Without this fix profilers that implement ICorProfilerCallback10 won't have their Release method called, and won't free any native resources they are keeping around.
Testing
Profiler tests were run on the change to detect any regressions
Risk
Low