Skip to content

Roslyn update response #43056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 3 commits into from
Oct 6, 2020
Merged

Roslyn update response #43056

jkotas merged 3 commits into from
Oct 6, 2020

Conversation

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Oct 5, 2020 •
edited by jkotas
Loading

  • Function pointer usage is updated.
  • CS8625: Cannot convert null literal to non-nullable reference type.
  • IDE0062: Local function can be made static.
  • CS8825: Return value must be non-null because parameter 'argument' is non-null.

/cc @ViktorHofer @jkotas @missymessa

@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Oct 5, 2020

Additional observed errors:

D:\runtime\src\libraries\System.Console\src\System\Console.cs(131,51): error CS8625: Cannot convert null literal to non-nullable reference type. [D:\runtime\src\libraries\System.Console\src\System.Console.csproj]
D:\runtime\src\libraries\System.Console\src\System\Console.cs(136,53): error CS8625: Cannot convert null literal to non-nullable reference type. [D:\runtime\src\libraries\System.Console\src\System.Console.csproj]
D:\runtime\src\libraries\System.Formats.Asn1\src\System\Formats\Asn1\AsnDecoder.GeneralizedTime.cs(147,19): error IDE0062: Local function can be made static [D:\runtime\src\libraries\System.Formats.Asn1\src\System.Formats.Asn1.csproj]
D:\runtime\src\libraries\System.Net.Sockets\src\System\Net\Sockets\SocketPal.Windows.cs(923,18): error IDE0062: Local function can be made static [D:\runtime\src\libraries\System.Net.Sockets\src\System.Net.Sockets.csproj]
D:\runtime\src\libraries\System.Net.Sockets\src\System\Net\Sockets\Socket.Tasks.cs(104,29): error IDE0062: Local function can be made static [D:\runtime\src\libraries\System.Net.Sockets\src\System.Net.Sockets.csproj]
D:\runtime\src\libraries\System.Private.Xml\src\System\Xml\Xsl\XsltOld\XsltCompileContext.cs(668,21): error CS8825: Return value must be non-null because parameter 'argument' is non-null. [D:\runtime\src\libraries\System.Private.Xml\src\System.Private.Xml.csproj]
D:\runtime\src\libraries\System.Private.Xml\src\System\Xml\Xsl\XsltOld\XsltCompileContext.cs(668,21): error CS8825: Return value must be non-null because parameter 'argument' is non-null. [D:\runtime\src\libraries\System.Private.Xml\src\System.Private.Xml.csproj]
D:\runtime\src\libraries\System.Security.Cryptography.Encoding\src\Internal\Cryptography\OidLookup.cs(139,18): error IDE0062: Local function can be made static [D:\runtime\src\libraries\System.Security.Cryptography.Encoding\src\System.Security.Cryptography.Encoding.csproj]

jkotas
jkotas reviewed Oct 5, 2020
View reviewed changes
@jkotas jkotas force-pushed the update_fptr_usage branch 3 times, most recently from 1479b88 to b3949bd Compare October 6, 2020 05:55
@jkotas jkotas force-pushed the update_fptr_usage branch from b3949bd to 0a878c3 Compare October 6, 2020 06:29
ViktorHofer
ViktorHofer reviewed Oct 6, 2020
View reviewed changes
@jkotas jkotas merged commit d1c0fa8 into dotnet:master Oct 6, 2020
@jkotas jkotas mentioned this pull request Oct 9, 2020
Merged
jkotas added a commit that referenced this pull request Oct 9, 2020
@AaronRobinsonMSFT @jkotas
Roslyn update response (#43056)
b54e566 
* Update function pointer syntax usage to official.

* Fix warnings with new Roslyn

Co-authored-by: Jan Kotas <[email protected]>
@jkotas jkotas mentioned this pull request Oct 9, 2020
Merged
ViktorHofer added a commit that referenced this pull request Oct 10, 2020
@dotnet-maestro @ViktorHofer
@AaronRobinsonMSFT @jkotas @jcouv @safern
[release/5.0] Update dependencies from dotnet/arcade (#43185)
db79f63 
* Update dependencies from https://github.com/dotnet/arcade build 20201006.7

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.ApiCompat
 From Version 5.0.0-beta.20474.4 -> To Version 5.0.0-beta.20506.7

* React to TargetFramework.Sdk change

* Roslyn update response (#43056)

* Update function pointer syntax usage to official.

* Fix warnings with new Roslyn

Co-authored-by: Jan Kotas <[email protected]>

* Adjust for roslyn change on ref parameters and NotNullIfNotNull (#42707)

* Adjust for roslyn change on ref parameters

* Adjust for roslyn change on NotNullIfNotNull

* Fix all configurations build

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
Co-authored-by: Aaron Robinson <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Julien Couvreur <[email protected]>
Co-authored-by: Santiago Fernandez Madero <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_fptr_usage branch September 2, 2021 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AaronRobinsonMSFT @jkotas @ViktorHofer @Dotnet-GitSync-Bot