use macros instead of functions in extra_libs.cmake

src/libraries/Native/Unix/System.IO.Compression.Native/extra_libs.cmake

@@ -1,5 +1,5 @@
 
-function(append_extra_compression_libs NativeLibsExtra)
+macro(append_extra_compression_libs NativeLibsExtra)
   if (CLR_CMAKE_TARGET_BROWSER)
       # nothing special to link
   elseif (CLR_CMAKE_TARGET_ANDROID)
@@ -10,5 +10,5 @@ function(append_extra_compression_libs NativeLibsExtra)
   else ()
       find_package(ZLIB REQUIRED)
   endif ()
-  set(${NativeLibsExtra} ${${NativeLibsExtra}} ${ZLIB_LIBRARIES} PARENT_SCOPE)
-endfunction(append_extra_compression_libs)
+  list(APPEND ${NativeLibsExtra} ${ZLIB_LIBRARIES})
+endmacro()

src/libraries/Native/Unix/System.Native/extra_libs.cmake

@@ -1,21 +1,18 @@
 
-function(append_extra_system_libs NativeLibsExtra)
-    set(EXTRA_LIBS)
-
+macro(append_extra_system_libs NativeLibsExtra)   
     if (CLR_CMAKE_TARGET_LINUX AND NOT CLR_CMAKE_TARGET_ANDROID)
-        list(APPEND EXTRA_LIBS rt)
+        list(APPEND ${NativeLibsExtra} rt)
     elseif (CLR_CMAKE_TARGET_FREEBSD)
-        list(APPEND EXTRA_LIBS pthread)
+        list(APPEND ${NativeLibsExtra} pthread)
         if (HAVE_INOTIFY)
             find_library(INOTIFY_LIBRARY inotify HINTS /usr/local/lib)
-            list(APPEND EXTRA_LIBS ${INOTIFY_LIBRARY})
+            list(APPEND ${NativeLibsExtra} ${INOTIFY_LIBRARY})
         endif ()
     elseif (CLR_CMAKE_TARGET_SUNOS)
-        list(APPEND EXTRA_LIBS socket)
+        list(APPEND ${NativeLibsExtra} socket)
     endif ()
 
     if (CLR_CMAKE_TARGET_IOS OR CLR_CMAKE_TARGET_TVOS)
-        list(APPEND EXTRA_LIBS "-framework Foundation")
+        list(APPEND ${NativeLibsExtra} "-framework Foundation")
     endif ()
-    set(${NativeLibsExtra} ${${NativeLibsExtra}} ${EXTRA_LIBS} PARENT_SCOPE)
-endfunction(append_extra_system_libs)
+endmacro()

src/libraries/Native/Unix/System.Net.Security.Native/extra_libs.cmake

@@ -1,5 +1,5 @@
 
-function(append_extra_security_libs NativeLibsExtra)
+macro(append_extra_security_libs NativeLibsExtra)
   if (HAVE_GSSFW_HEADERS)
      find_library(LIBGSS NAMES GSS)
      if(LIBGSS STREQUAL LIBGSS-NOTFOUND)
@@ -19,5 +19,5 @@ function(append_extra_security_libs NativeLibsExtra)
      endif()
   endif()
 
-  set(${NativeLibsExtra} ${${NativeLibsExtra}} ${LIBGSS} PARENT_SCOPE)
-endfunction(append_extra_compression_libs)
+  list(APPEND ${NativeLibsExtra} ${LIBGSS})
+endmacro()

src/libraries/Native/Unix/System.Security.Cryptography.Native/extra_libs.cmake

@@ -1,5 +1,5 @@
 
-function(append_extra_cryptography_libs NativeLibsExtra)
+macro(append_extra_cryptography_libs NativeLibsExtra)
     if(CMAKE_STATIC_LIB_LINK)
        set(CMAKE_FIND_LIBRARY_SUFFIXES .a)
     endif(CMAKE_STATIC_LIB_LINK)
@@ -32,10 +32,8 @@ function(append_extra_cryptography_libs NativeLibsExtra)
 
     if (FEATURE_DISTRO_AGNOSTIC_SSL)
         # Link with libdl.so to get the dlopen / dlsym / dlclose
-        set(EXTRA_LIBS dl)
+        list(APPEND ${NativeLibsExtra} dl)
     else()
-        set(EXTRA_LIBS ${OPENSSL_CRYPTO_LIBRARY} ${OPENSSL_SSL_LIBRARY})
+        list(APPEND ${NativeLibsExtra} ${OPENSSL_CRYPTO_LIBRARY} ${OPENSSL_SSL_LIBRARY})
     endif()
-
-    set(${NativeLibsExtra} ${${NativeLibsExtra}} ${EXTRA_LIBS} PARENT_SCOPE)
-endfunction(append_extra_cryptography_libs)
+endmacro()