Skip to content

Disable C11 compat in libunwind #45875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agocke wants to merge 1 commit into from
Closed

Disable C11 compat in libunwind #45875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/pal/src/libunwind/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
# It overwrites the one found in upstream
project(unwind)

# Disable C11 compat
unset(CMAKE_C_STANDARD)
unset(CMAKE_C_STANDARD_REQUIRED)
Comment on lines +5 to +7
Copy link
Member

@am11 am11 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libunwind is a C library, I think setting project(unwind C) on line 3 would be a more appropriate fix. cc @janvorli

Copy link
Member

@am11 am11 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to

runtime/src/libraries/Native/Windows/System.IO.Compression.Native/zlib/CMakeLists.txt

Line 4 in 03059a9

project(zlib C)
and many other examples in the repo.


set(CMAKE_INCLUDE_CURRENT_DIR ON)

# define variables for the configure_file below
Expand Down