Skip to content

[RyuJIT] Unroll StartsWith/SequenceEqual for ([ReadOnly]Span<char>, const-string) #46392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EgorBo wants to merge 15 commits into from
Closed

[RyuJIT] Unroll StartsWith/SequenceEqual for ([ReadOnly]Span<char>, const-string) #46392

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
389a1a8
Optimize `span.StartsWith("cstr")` to `span.Length >= 4 && *(span._po…
EgorBo Dec 24, 2020
22e2cc2
Optimize `span.StartsWith("cstr")` to `span.Length >= 4 && *(span._po…
EgorBo Dec 24, 2020
7e24372
Extract into a separate function
EgorBo Dec 25, 2020
a6ecf24
Add SequenceEqual support
EgorBo Dec 25, 2020
3b1df76
Add "ignoreCase" support, fix a bug, formatting
EgorBo Dec 25, 2020
24c33e9
Fix "ignoreCase"
EgorBo Dec 25, 2020
d465e60
Clean up
EgorBo Dec 25, 2020
d1e5931
Formatting
EgorBo Dec 25, 2020
0561cac
Add tests
EgorBo Dec 25, 2020
1f25caf
Cover more methods, add ignore case support.
EgorBo Dec 25, 2020
8cdda9b
Remove redundant intrinsics
EgorBo Dec 25, 2020
790df25
Handle "..".AsSpan()
EgorBo Dec 25, 2020
3d2ded2
More tests, formatting
EgorBo Dec 25, 2020
27232d8
Fix failing tests
EgorBo Dec 26, 2020
e108914
Clean up
EgorBo Dec 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean up
  • Loading branch information
@EgorBo
EgorBo committed Dec 26, 2020
commit e108914e2c564733b44e4a37b434eeffe7b90fe5
16 changes: 6 additions & 10 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4343,12 +4343,8 @@ GenTree* Compiler::impIntrinsic(GenTree* newobjThis,
assert((ni == NI_System_MemoryExtensions_Equals) || (ni == NI_System_MemoryExtensions_StartsWith));

// See StringComparison.cs
const int CurrentCulture = 0;
const int CurrentCultureIgnoreCase = 1;
const int InvariantCulture = 2;
const int InvariantCultureIgnoreCase = 3;
const int Ordinal = 4;
const int OrdinalIgnoreCase = 5;
const int Ordinal = 4;
const int OrdinalIgnoreCase = 5;

// Fetch mode from the last argument.
int mode = (int)impStackTop(0).val->AsIntCon()->IconValue();
Expand Down Expand Up @@ -4716,13 +4712,13 @@ GenTree* Compiler::impUnrollSpanComparisonWithStrCon(GenTree* span,
return nullptr;
}

bool allAreLetters = true;
UINT64 strAsUlong = 0;
bool allAreLetters = true;
UINT64 strAsUlong = 0;

for (int i = 0; i < strLen; i++)
{
UINT64 strChar = str[i];
if (strChar > '\x007f')
if (strChar > 127)
{
// str is not ASCII - bail out.
return nullptr;
Expand Down Expand Up @@ -4789,7 +4785,7 @@ GenTree* Compiler::impUnrollSpanComparisonWithStrCon(GenTree* span,
if (ignoreCase)
{
ssize_t lowerBitMask = genTrimUnsignedValue(cmpType, 0x0020002000200020ULL);

// Set "is lower" bits in all chars
spanDataIndir = gtNewOperNode(GT_OR, cmpType, spanDataIndir, gtNewIconNode(lowerBitMask, cmpType));
}
Expand Down