Skip to content

Implement System.Runtime.InteropServices.CLong/CULong/NFloat #46401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 23 commits into from
Jan 12, 2021
Merged

Implement System.Runtime.InteropServices.CLong/CULong/NFloat #46401

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e8872a4
Implement managed side of CLong/CULong/NFloat.
jkoritzinsky Dec 24, 2020
3b7693b
Make CLong, CULong, and NFloat intrinsically handled correctly by the…
jkoritzinsky Dec 25, 2020
e598892
Add framework tests for CLong, CULong, and NFloat.
jkoritzinsky Dec 25, 2020
c9d8d13
Add interop test of CLong to validate calling convention semantics.
jkoritzinsky Dec 25, 2020
0aeaaf7
Update CULong.cs
jkoritzinsky Dec 25, 2020
2baa10d
Fix implicit conversions.
jkoritzinsky Dec 25, 2020
57ba638
Merge branch 'clong' of github.com:jkoritzinsky/runtime into clong
jkoritzinsky Dec 25, 2020
d2da1d8
Fix overflow and equality test failures.
jkoritzinsky Jan 4, 2021
f141023
Fix formatting.
jkoritzinsky Jan 4, 2021
e587cfc
Fix formatting and add function header.
jkoritzinsky Jan 4, 2021
5b9d7a3
Add doc comments.
jkoritzinsky Jan 4, 2021
62acb9e
Don't throw on float out of range. Rename tests.
jkoritzinsky Jan 4, 2021
a365f26
Rewrite EqualsTest implementations more straightforward.
jkoritzinsky Jan 8, 2021
b114e7e
Fix NFloat tests.
jkoritzinsky Jan 8, 2021
265a914
Use .Equals instead of ==
jkoritzinsky Jan 8, 2021
5404cec
Use ToString directly instead of hard coding the expected value.
jkoritzinsky Jan 8, 2021
cac95b4
Update the emitted assembly stub's thiscall retbuf support for x86 to…
jkoritzinsky Jan 8, 2021
59785f5
Add sizeof tests.
jkoritzinsky Jan 8, 2021
65eddf7
Add test with struct containing CLong.
jkoritzinsky Jan 8, 2021
3e2ded1
Merge branch 'master' of github.com:dotnet/runtime into clong
jkoritzinsky Jan 11, 2021
314e03a
Disable ThisCallTest on Mono due to #46820
jkoritzinsky Jan 11, 2021
b285a8a
Merge branch 'master' of github.com:dotnet/runtime into clong
jkoritzinsky Jan 11, 2021
19e0063
validate type name.
jkoritzinsky Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable ThisCallTest on Mono due to #46820
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Jan 11, 2021
commit 314e03ae2c31ccc04c54b423fa9c230662df6233
3 changes: 3 additions & 0 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,9 @@
<ExcludeList Include="$(XunitTestBinBase)/Interop/StructPacking/StructPacking/**">
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/Miscellaneous/ThisCall/ThisCallTest/**">
<Issue>https://github.com/dotnet/runtime/issues/46820</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/Convert/ldind_conv/**">
<Issue>needs triage</Issue>
</ExcludeList>
Expand Down