Skip to content

Process.Start() failure should include path #46417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 19 commits into from
Jul 14, 2021
Merged

Process.Start() failure should include path #46417

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a98caf7
Adding ProcessStartException
batzen Oct 3, 2020
b07d1a2
Reverting ProcessStartException
batzen Oct 11, 2020
c10f235
First version
batzen Dec 16, 2020
08ee21a
Fixing merge issue
batzen Dec 16, 2020
5fb88c3
Using interop call instead of intermediate exception to get error msg
batzen Dec 16, 2020
e8a7cf8
Fixing typo
batzen Dec 26, 2020
7e58fad
Change checks for exception message
batzen Dec 27, 2020
68ccd75
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic…
batzen Jan 4, 2021
7384df6
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic…
batzen Jan 4, 2021
81b963e
Using common method to create exception and updating error message
batzen Jan 4, 2021
24d4232
Fixing merge mistake
batzen Mar 16, 2021
40f8c7a
Using AssertExtensions.ThrowsContains
batzen Mar 16, 2021
29a22ef
Fixing code for unix
batzen Mar 18, 2021
f72a1f6
Merge branch 'main' into issues/39928
jeffhandley Jul 9, 2021
ba64c57
Merge branch 'main' into issues/39928
jeffhandley Jul 13, 2021
c885672
Address PR feedback
jeffhandley Jul 14, 2021
0b91e4e
Merge branch 'main' into jeffhandley/39928
jeffhandley Jul 14, 2021
09dc7e7
Apply suggestions from code review
jeffhandley Jul 14, 2021
e6c160a
Fix ErrorInfo type reference
jeffhandley Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic… 
…s/Process.cs

Co-authored-by: Adam Sitnik <[email protected]>
  • Loading branch information
@batzen @adamsitnik
batzen and adamsitnik committed Mar 27, 2021
commit 68ccd75896e8aec0b63ba3c921502ee1b6b3f3bd
1 change: 0 additions & 1 deletion src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,6 @@ public bool Start()
{
throw new InvalidOperationException(SR.FileNameMissing);
}

if (startInfo.StandardInputEncoding != null && !startInfo.RedirectStandardInput)
{
throw new InvalidOperationException(SR.StandardInputEncodingNotAllowed);
Expand Down