Skip to content

Bugfix: System.Xml.Serialization: Compiler.GetTempAssemblyName is not deterministic under .NET Core #46499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
10 commits merged into from
Jul 18, 2021
Merged

Bugfix: System.Xml.Serialization: Compiler.GetTempAssemblyName is not deterministic under .NET Core #46499

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c8d9b20
Bugfix: System.Xml.Serialization: Compiler.GetTempAssemblyName is not…
TalAloni Jan 1, 2021
49327d3
Remove trailing whitespace
TalAloni Jan 1, 2021
384ceac
Use truncated SHA512
TalAloni Feb 20, 2021
bfb2139
Fixed compilation
TalAloni Feb 20, 2021
a86258b
Dispose SHA512 instance
TalAloni Feb 20, 2021
ef86269
Fixed compilation
TalAloni Feb 20, 2021
0f4257a
Merge branch 'main' of https://github.com/dotnet/runtime
TalAloni Jun 16, 2021
5ab9344
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
TalAloni Jul 9, 2021
1e057b4
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
TalAloni Jul 9, 2021
7a96f18
Update Compiler.cs
stephentoub Jul 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Private.Xml/src/System.Private.Xml.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@
<Reference Include="System.Runtime.Extensions" />
<Reference Include="System.Runtime.InteropServices" />
<Reference Include="System.Security.Cryptography.Algorithms" />
<Reference Include="System.Security.Cryptography.Primitives" />
<Reference Include="System.Text.Encoding.Extensions" />
<Reference Include="System.Text.RegularExpressions" />
<Reference Include="System.Threading" />
Expand Down
13 changes: 12 additions & 1 deletion src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Globalization;
using System.Runtime.CompilerServices;
using System.Diagnostics.CodeAnalysis;
using System.Security.Cryptography;

namespace System.Xml.Serialization
{
Expand Down Expand Up @@ -89,7 +90,17 @@ internal TextWriter Source

internal static string GetTempAssemblyName(AssemblyName parent, string? ns)
{
return parent.Name + ".XmlSerializers" + (ns == null || ns.Length == 0 ? "" : "." + ns.GetHashCode());
return parent.Name + ".XmlSerializers" + (ns == null || ns.Length == 0 ? "" : "." + GetPersistentHashCode(ns));
}

private static uint GetPersistentHashCode(string value)
{
byte[] valueBytes = System.Text.Encoding.UTF8.GetBytes(value);
using (SHA512 sha512 = SHA512.Create())
{
byte[] hash = sha512.ComputeHash(valueBytes);
return (uint)(hash[0] << 24 | hash[1] << 16 | hash[2] << 8 | hash[3]);
}
}
}
}