improve renegotiation ssl tests #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Outerloop test failures are unrelated. Updated renegotiate tests passed. |
stephentoub
reviewed
Dec 3, 2019
| // There's no good way to ensure renegotiation happened in the test. | ||
| // Under the debugger, we can see this test hits the renegotiation codepath. | ||
| // Renegotiation will trigger another validation callback/ | ||
| Assert.True(validationCount > 1); |
Member
There was a problem hiding this comment.
Suggested change
| Assert.True(validationCount > 1); | |
| Assert.InRange(validationCount, 2, int.MaxValue); |
stephentoub
reviewed
Dec 3, 2019
| // There's no good way to ensure renegotiation happened in the test. | ||
| // Under the debugger, we can see this test hits the renegotiation codepath. | ||
| // renegotiation will trigger validation callback again. | ||
| Assert.True(validationCount > 1); |
Member
There was a problem hiding this comment.
Suggested change
| Assert.True(validationCount > 1); | |
| Assert.InRange(validationCount, 2, int.MaxValue); |
stephentoub
approved these changes
Dec 3, 2019
davidsh
approved these changes
Dec 3, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve test to make sure we actually do renegotiation.
It is curious that we actually never set _pendingReHandshake to true in production code.
I will address it as part of #453