Skip to content

Stops logging MSBuild errors when AOT compiler writes to stderr #47057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 2 commits into from
Jan 19, 2021
Merged

Stops logging MSBuild errors when AOT compiler writes to stderr #47057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c52fd5
Stops logging MSBuild errors when AOT compiler writes to stderr
Jan 15, 2021
8cfd03f
Write warnings for stderr
Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/testing/tests.mobile.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@
<BundleAssemblies Condition="'$(RunAOTCompilation)' != 'true'" Include="$(PublishDir)*.dll" />
</ItemGroup>

<RemoveDir Directories="$(BundleDir)" />

<MonoAOTCompiler Condition="'$(RunAOTCompilation)' == 'true'"
CompilerBinaryPath="$(MicrosoftNetCoreAppRuntimePackNativeDir)cross\$(PackageRID)\mono-aot-cross"
Mode="Full"
Expand All @@ -119,7 +121,6 @@

<!-- Run App bundler, it uses AOT libs (if needed), link all native bits, compile simple UI (written in ObjC)
and produce an app bundle (with xcode project) -->
<RemoveDir Directories="$(BundleDir)" />
<AppleAppBuilderTask
TargetOS="$(TargetOS)"
Arch="$(TargetArchitecture)"
Expand Down
8 changes: 7 additions & 1 deletion src/tasks/Common/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public static string RunProcess(
{
if (!silent)
{
LogError(e.Data);
LogWarning(e.Data);
outputBuilder.AppendLine(e.Data);
}
errorBuilder.AppendLine(e.Data);
Expand Down Expand Up @@ -124,6 +124,12 @@ public static void LogInfo(string? msg, MessageImportance importance=MessageImpo
Logger?.LogMessage(importance, msg);
}

public static void LogWarning(string? msg)
{
if (msg != null)
Logger?.LogWarning(msg);
}

public static void LogError(string? msg)
{
if (msg != null)
Expand Down