-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Only pass the method context when tracking transitions. #47238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only pass the method context when tracking transitions. #47238
Conversation
|
|
…o track transitions
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Jan Kotas <[email protected]>
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
sandreenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jit changes look fine.
…runtime into reverse-pinvoke-helper-opt
|
Why is the last commit needed? These callouts should be limited to JIT only. We would have to introduce a whole new separate R2R image flavor to make that work. It is not something we want to do. |
|
I may have been a little overzealous on adding all the R2R helpers. I’ll go remove the e R2R helpers and just update the JIT helpers on the Crossgen2 side (which is all I really needed to do on that commit) |
This reverts commit 80a4749.
…helpers since they won't be used.
|
Can you take a look at the 2 new commits and let me know what you think? |
|
LGTM otherwise. |
9bb318b to
c1a881d
Compare
Create a new helper instead of modifying an existing one. Only track transitions when we absolutely need to.
Fixes #47223
cc: @dotnet/jit-contrib