Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Create a new helper instead of modifying an existing one. Only track transitions when we absolutely need to.

Fixes #47223

cc: @dotnet/jit-contrib

@jkotas
Copy link
Member

jkotas commented Jan 20, 2021

ReadyToRunInfo::GetEntryPoint should have something like this:

if (CORProfilerTrackTransitions() && pMD->HasUnmanagedCallersOnlyAttribute())
{
   pMD->SetProfilerRejectedPrecompiledCode();
   goto done;
}

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghost
Copy link

ghost commented Jan 20, 2021

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@sandreenko sandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jit changes look fine.

@jkotas
Copy link
Member

jkotas commented Jan 20, 2021

Why is the last commit needed? These callouts should be limited to JIT only. We would have to introduce a whole new separate R2R image flavor to make that work. It is not something we want to do.

@jkotas jkotas removed the auto-merge label Jan 20, 2021
@jkoritzinsky
Copy link
Member Author

I may have been a little overzealous on adding all the R2R helpers. I’ll go remove the e R2R helpers and just update the JIT helpers on the Crossgen2 side (which is all I really needed to do on that commit)

@jkoritzinsky
Copy link
Member Author

Can you take a look at the 2 new commits and let me know what you think?

@jkotas
Copy link
Member

jkotas commented Jan 20, 2021

LGTM otherwise.

@jkoritzinsky jkoritzinsky force-pushed the reverse-pinvoke-helper-opt branch from 9bb318b to c1a881d Compare January 20, 2021 23:52
@jkoritzinsky jkoritzinsky merged commit 7225baf into dotnet:master Jan 21, 2021
@jkoritzinsky jkoritzinsky deleted the reverse-pinvoke-helper-opt branch January 21, 2021 02:48
@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnmanagedCallersOnly performance regression and R2R breaking change in

3 participants