Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
1863d35
[WIP] - Start crypto worker and initialize channel.
AaronRobinsonMSFT Mar 10, 2021
d5c4199
Make Emscripten minimizer happy by using getters instead of fields.
AaronRobinsonMSFT Mar 10, 2021
4e2d738
Add new System.Security.Cryptography.Native.Browser library.
AaronRobinsonMSFT Mar 11, 2021
5ec3db7
Initialize WebWorker earlier.
AaronRobinsonMSFT Mar 11, 2021
c7e3888
Update logging and be less strict for output buffer size.
AaronRobinsonMSFT Mar 11, 2021
47b5e6c
Focus SHA tests for non-browser and browser DOM scenarios.
AaronRobinsonMSFT Mar 11, 2021
891b23c
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 11, 2021
d4ea7d6
Add missing namespaces to test builds.
AaronRobinsonMSFT Mar 12, 2021
8062a2f
Additional locations for that need the crypto_worker.js file.
AaronRobinsonMSFT Mar 12, 2021
2b38fdd
Add new JS and native binaries... everywhere.
AaronRobinsonMSFT Mar 12, 2021
84dd60b
Reference the correct location for the webworker file.
AaronRobinsonMSFT Mar 13, 2021
36b2f56
Specify the correct native directory path for the JS WebWorker file.
AaronRobinsonMSFT Mar 13, 2021
80087a5
Only enable Crypto WebWorker when running in the browser scenario.
AaronRobinsonMSFT Mar 15, 2021
6a3b8a6
Condition more tests based on platform Crypto support needed.
AaronRobinsonMSFT Mar 15, 2021
d78f0e2
Rename crypto_worker.js to dotnet_crypto_worker.js
AaronRobinsonMSFT Mar 15, 2021
2e74b1f
Missing installer directory.
AaronRobinsonMSFT Mar 15, 2021
7eb087d
Style
AaronRobinsonMSFT Mar 16, 2021
b04d0cc
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 16, 2021
925dcc0
Change internal API name to use generic "digest" name instead
AaronRobinsonMSFT Mar 16, 2021
753c57b
Add test for not supported platform crypto WRT SHA
AaronRobinsonMSFT Mar 17, 2021
74a4e7e
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 17, 2021
b217fc4
Browser uses Unix binary builds so removing Windows placeholder.
AaronRobinsonMSFT Mar 17, 2021
a95e9d6
Add libSystem.Security.Cryptography.Native.Browser.a for Windows build.
AaronRobinsonMSFT Mar 18, 2021
ce6d2b1
More Windows build changes.
AaronRobinsonMSFT Mar 18, 2021
42eac88
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 23, 2021
55dfe74
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 24, 2021
f777cb3
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 25, 2021
c13a76e
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 25, 2021
f2e28fc
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 25, 2021
c749ab5
Merge remote-tracking branch 'upstream/main' into wasm_crypto
AaronRobinsonMSFT Mar 29, 2021
4c5a3e0
Merge remote-tracking branch 'upstream/main' into wasm_crypto
lewing Apr 22, 2021
44ea919
Merge branch 'main' into wasm_crypto
lewing Apr 22, 2021
742cbc3
Fix the js inclusion logic
lewing Apr 22, 2021
76dd72b
Add libSystem.Globalization.Native explicitly
lewing Apr 23, 2021
bc7ec42
Merge branch 'main' into wasm_crypto
jeffhandley May 11, 2021
3eb7b2f
Merge branch 'main' into wasm_crypto
jeffhandley May 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Initialize WebWorker earlier.
 - Moved ChannelLib to be pre-js so worker init can happen earlier.
Add function for WebWorker shutdown. This is needed to not deadlock test
harness.
Document where SubtleCrypto API was looked for in the v8 test harness. It
was not found.
  • Loading branch information
AaronRobinsonMSFT committed Mar 11, 2021
commit 5ec3db7411ba8569a64778e4c8d8b858c282fb55
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var CryptoWebWorkerLib = {
var response = MONO.mono_wasm_crypto.channel.send_msg(JSON.stringify(msg));
var digest = JSON.parse(response);
if (digest.length !== output_len) {
throw "SHA HASH: Unexpected output length";
throw "SHA HASH: Unexpected output length: " + digest.length + ", expected: " + output_len;
}

Module.HEAPU8.set(digest, output_buffer);
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ $(BUILDS_OBJ_DIR):
mkdir -p $$@

$(NATIVE_BIN_DIR)/dotnet.js: $(BUILDS_OBJ_DIR)/driver.o $(BUILDS_OBJ_DIR)/pinvoke.o $(BUILDS_OBJ_DIR)/corebindings.o runtime/library_mono.js runtime/binding_support.js runtime/dotnet_support.js runtime/library_channel.js $(SYSTEM_NATIVE_LIBDIR)/pal_random.js $(SYSTEM_CRYPTO_NATIVE_LIBDIR)/pal_crypto_webworker.js $(2) | $(NATIVE_BIN_DIR)
$(EMCC) $(EMCC_FLAGS) $(1) --js-library runtime/library_mono.js --js-library runtime/binding_support.js --js-library runtime/dotnet_support.js --post-js runtime/library_channel.js --js-library $(SYSTEM_NATIVE_LIBDIR)/pal_random.js --js-library $(SYSTEM_CRYPTO_NATIVE_LIBDIR)/pal_crypto_webworker.js $(BUILDS_OBJ_DIR)/driver.o $(BUILDS_OBJ_DIR)/pinvoke.o $(BUILDS_OBJ_DIR)/corebindings.o $(2) -o $(NATIVE_BIN_DIR)/dotnet.js $(3)
$(EMCC) $(EMCC_FLAGS) $(1) --js-library runtime/library_mono.js --js-library runtime/binding_support.js --js-library runtime/dotnet_support.js --pre-js runtime/library_channel.js --js-library $(SYSTEM_NATIVE_LIBDIR)/pal_random.js --js-library $(SYSTEM_CRYPTO_NATIVE_LIBDIR)/pal_crypto_webworker.js $(BUILDS_OBJ_DIR)/driver.o $(BUILDS_OBJ_DIR)/pinvoke.o $(BUILDS_OBJ_DIR)/corebindings.o $(2) -o $(NATIVE_BIN_DIR)/dotnet.js $(3)

$(BUILDS_OBJ_DIR)/pinvoke-table.h: $(PINVOKE_TABLE) | $(BUILDS_OBJ_DIR)
if cmp -s $(PINVOKE_TABLE) $$@ ; then : ; else cp $(PINVOKE_TABLE) $$@ ; fi
Expand Down
22 changes: 21 additions & 1 deletion src/mono/wasm/runtime/crypto_worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var ChannelWorker = {
get MSG_SIZE_IDX() { return 1; }

// Communication states.
get STATE_SHUTDOWN() { return -1; } // Shutdown
get STATE_IDLE() { return 0; }
get STATE_REQ() { return 1; }
get STATE_RESP() { return 2; }
Expand All @@ -32,13 +33,16 @@ var ChannelWorker = {
// Read in request
var req = this._read_request();
// console.log("Request: " + req);
if (req === this.STATE_SHUTDOWN)
break;

var resp = null;
try {
// Perform async action based on request
resp = await async_call(req);
}
catch (err) {
console.log("Request error: " + err);
resp = JSON.stringify(err);
}

Expand All @@ -61,6 +65,10 @@ var ChannelWorker = {
if (state === this.STATE_REQ)
break;

// Shutdown the worker.
if (state === this.STATE_SHUTDOWN)
return this.STATE_SHUTDOWN;

// Reset the size and transition to await state.
Atomics.store(this.comm, this.MSG_SIZE_IDX, 0);
Atomics.store(this.comm, this.STATE_IDX, this.STATE_AWAIT);
Expand Down Expand Up @@ -134,6 +142,14 @@ async function sha_hash(type, data) {
throw "CRYPTO: Unknown SHA: " + type;
}

// [TODO] The 'crypto' API is not available within the current
// v8 test harness. The following were tried:
// self
// document
// this
// globalThis
//
// The below works in the browser scenario.
var digest = await crypto.subtle.digest(sha_type, data);
return Array.from(new Uint8Array(digest));
}
Expand All @@ -154,6 +170,10 @@ var s_channel;

// Initialize WebWorker
onmessage = function (p) {
s_channel = ChannelWorker.create(p.data.comm_buf, p.data.msg_buf, p.data.msg_char_len);
var data = p;
if (p.data !== undefined) {
data = p.data;
}
s_channel = ChannelWorker.create(data.comm_buf, data.msg_buf, data.msg_char_len);
s_channel.await_request(async_call);
}
12 changes: 12 additions & 0 deletions src/mono/wasm/runtime/library_channel.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Module [ 'channel' ] = {
get COMM_LAST_IDX() { return this.MSG_SIZE_IDX; }

// Communication states.
get STATE_SHUTDOWN() { return -1; } // Shutdown
get STATE_IDLE() { return 0; }
get STATE_REQ() { return 1; }
get STATE_RESP() { return 2; }
Expand Down Expand Up @@ -45,6 +46,17 @@ Module [ 'channel' ] = {
return this._read_response();
}

shutdown() {
if (Atomics.load(this.comm, this.STATE_IDX) !== this.STATE_IDLE) {
throw "OWNER: Invalid sync communication channel state.";
}

// Notify webworker
Atomics.store(this.comm, this.MSG_SIZE_IDX, 0);
Atomics.store(this.comm, this.STATE_IDX, this.STATE_SHUTDOWN);
Atomics.notify(this.comm, this.STATE_IDX);
}

_send_request(msg) {
var state;
const msg_len = msg.length;
Expand Down
18 changes: 12 additions & 6 deletions src/mono/wasm/runtime/library_mono.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
*/

var MonoSupportLib = {
$MONO__postset: 'MONO.export_functions (Module);',
$MONO__postset: 'MONO.export_functions (Module); MONO._initialize_workers ();',
$MONO: {
pump_count: 0,
timeout_queue: [],
Expand Down Expand Up @@ -1707,7 +1707,6 @@ var MonoSupportLib = {
var chan = Module.channel.create();
var worker = new Worker ("crypto_worker.js");
worker.postMessage ({
salutation:"Message from main",
comm_buf: chan.get_comm_buffer(),
msg_buf: chan.get_msg_buffer(),
msg_char_len: chan.get_msg_len()
Expand All @@ -1716,6 +1715,14 @@ var MonoSupportLib = {
MONO.mono_wasm_crypto.worker = worker;
},

_shutdown_workers: function () {
console.debug ("MONO_WASM: WebWorkers shutdown");
var chan = MONO.mono_wasm_crypto.channel;
if (chan !== null) {
chan.shutdown ();
}
},

_finalize_startup: function (args, ctx) {
var loaded_files_with_debug_info = [];

Expand Down Expand Up @@ -1753,12 +1760,11 @@ var MonoSupportLib = {
tz = Intl.DateTimeFormat().resolvedOptions().timeZone;
} catch {}
MONO.mono_wasm_setenv ("TZ", tz || "UTC");

// Now that the runtime has been loaded, spin off any web workers needed
// for ancillary operations.
MONO._initialize_workers ();
MONO.mono_wasm_runtime_ready ();
args.loaded_cb ();

// [TODO] Shutdown workers when run under test environment
// MONO._shutdown_workers();
},

_load_assets_and_runtime: function (args) {
Expand Down