Skip to content

ECMA spec addendum dealing with static interface methods #49558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trylek merged 16 commits into from
May 14, 2021
Merged

ECMA spec addendum dealing with static interface methods #49558

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7d95be3
ECMA spec addendum dealing with static interface methods
trylek Mar 12, 2021
99d118f
Address initial PR feedback; clarify most of the relevant sections
trylek Mar 20, 2021
9096eed
Remove trailing whitespace triggering Markdownlint failures
trylek Mar 20, 2021
d6110be
Attempt to fix the table
trylek Mar 21, 2021
af2643b
Tiny fix + initial attempt at providing examples of static interface …
trylek Mar 22, 2021
9108d76
Initial self-review fixes, the woes of code that doesn't compile
trylek Mar 22, 2021
aa789da
More fixes
trylek Mar 22, 2021
aafce99
Yet more fixes
trylek Mar 22, 2021
c51084c
Removed superfluous type DoublePair; more syntax fixes
trylek Mar 23, 2021
b122c42
More syntax fixes :-)
trylek Mar 23, 2021
677f6e1
Clarify naming as the local actually represents the inverse factorial
trylek Mar 23, 2021
01e5ded
Clarify the .override directive per Aleksey's PR feedback
trylek Mar 23, 2021
48b020c
Address additional David's and Aleksey's PR feedback
trylek Mar 25, 2021
d596870
Clarify that the MethodImpls must point to the same class, not base
trylek Apr 20, 2021
9027cd6
Update docs/design/specs/Ecma-335-Augments.md
davidwrighton May 13, 2021
e959fb5
Update docs/design/specs/Ecma-335-Augments.md
davidwrighton May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove trailing whitespace triggering Markdownlint failures
  • Loading branch information
@trylek
trylek committed Apr 20, 2021
commit 9096eed5d1d4cfd244cadfba906937b1cdd46db5
6 changes: 3 additions & 3 deletions docs/design/specs/Ecma-335-Augments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ the interface.

* If the current class is not abstract and there are any interface methods that still have
empty slots (i.e. slots with empty lists) for this class and all classes in its inheritance
chain, then the program is invalid.
chain, then the program is invalid.

### II.12.2.1, Interface implementation examples (page 159)

Expand Down Expand Up @@ -603,7 +603,7 @@ virtual static method (paragraph *II.10.3*).
(Edit the paragraph "Correctness:" second from the bottom of page 316:)

The `constrained.` prefix will be immediately followed by a `ldftn`, `call` or `callvirt`
instruction. *thisType* shall be a valid `typedef`, `typeref`, or `typespec` metadata token.
instruction. *thisType* shall be a valid `typedef`, `typeref`, or `typespec` metadata token.

(Edit the paragraph "Verifiability" at the bottom of page 316:)

Expand All @@ -624,7 +624,7 @@ The metadata token carries sufficient information to determine whether the call
(non-virtual or virtual) method, an instance method, a virtual instance method, or a global function. In all of
these cases the destination address is determined entirely from the metadata token. (Contrast this with the
`callvirt` instruction for calling virtual instance methods, where the destination address also depends upon
the exact type of the instance reference pushed before the `callvirt`; see below.)
the exact type of the instance reference pushed before the `callvirt`; see below.)

(Edit numbered list in the middle of the page 342):

Expand Down